-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private URL -- UI Improvements #3174
Comments
Today @djbrooke @mheppler and I met to discuss the Private URL feature and the state of the branch, open issues, and pull request. Mike will be working on some of the changes he suggested above so I'll pass this issue to him. The work should be done in the 1012-private-url branch, which pull request #3111 is based on. After switching to the branch, you must run the SQL update at Items 5 and 7 should be discussed with @eaquigley Item 10 might be challenging to implement based on my reading of http://stackoverflow.com/questions/3356546/embedding-a-link-or-other-html-in-a-jsf-message From my perspective, the other items a mix of fantastic ideas (thanks!) and stuff that I don't have strong opinion about. I would suggest asking the stakeholders named in the BRD at https://docs.google.com/document/d/1FT47QkZKcmjSgRnePaJO2g1nzcotLyN3Yb2ORvBr6cs/edit?usp=sharing if there is any doubt on if something should change. |
…gested UI improvements. [ref #3174]
Also changed messagePanel to blue info on create.
@mheppler I got the "Close" button to properly set privateUrlWasJustCreated to false in f515e4b but please not that I changed the FIXME to reflect the fact that there's a related known issue I just discovered in this area. The bug is that if you click the "X" in the upper right corner rather than the "Close" button (or the "Disable Private URL" button) the green "Success" message doesn't go away. Basically, I don't know how to make it so that Here's a handy screenshot of the "X" in the upper right of the Bootstrap "modal" I'm talking about: Oh, and I copied item 12 about the docs to #3138 and gave it to @eaquigley since that issue is about docs. That way you can each have an issue. 😄 |
@mheppler it looks like the section title and anchor changed at a54d5e8 so this key in the Bundle should change (I would think):
The new anchor seems to be dataset-management.html#private-url-for-reviewing-an-unpublished-dataset |
…avigation issue on confirm dialog. [ref #3174]
Fixed User Guide link in Private URL dialog. Fixed "X" close dialog navigation issue on confirm dialog. Passing back to @pdurbin to fine tune the backing bean and how the "Success!" msg is displayed and removed. |
@mheppler I checked with @scolapasta and he knew immediately how to fix the delay we were seeing. I needed to switch it from "onclick" to "oncomplete", which did the trick. I rolled it into what I hope is the final commit for this branch and pull request: 50ae521 Moving to QA. The pull request is #3111. |
Looks good, closing. |
UI improvements to the Private URL (#1012) project.
Maybe we can provide a link to open the Private URL popup.The text was updated successfully, but these errors were encountered: