Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private URL: When a contributor deletes a draft of a published dataset with privateURL defined, role is not cleared. #3201

Closed
kcondon opened this issue Jul 6, 2016 · 4 comments
Closed

Private URL: When a contributor deletes a draft of a published dataset with privateURL defined, role is not cleared. #3201

kcondon opened this issue Jul 6, 2016 · 4 comments
Labels
Feature: Permissions Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
4.5 - Metadata Ex...

Comments

@kcondon
Copy link
Contributor

kcondon commented Jul 6, 2016 •
edited by djbrooke
Loading

When a contributor deletes a draft of a published dataset that has a privateURL defined, the role assignment that identifies a privateURL is not removed but the dataset draft is. This can be observed by seeing the privateURL blue banner still displaying when visiting the dataset as an admin.

This does not happen in v4.4 but happens in the private url branch.

See related ticket: #3200
@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev Type: Bug a defect Feature: Permissions labels Jul 6, 2016
@kcondon kcondon added this to the 4.5 milestone Jul 6, 2016
@kcondon kcondon mentioned this issue Jul 6, 2016
Closed
pdurbin added a commit that referenced this issue Jul 8, 2016
@pdurbin
Private URL: add tests to exercise #3200 and #3201
4015d35
@pdurbin
Copy link
Member

pdurbin commented Jul 8, 2016

I added some tests to exercise this bug ( #3200 (comment) ) but I'd like to keep the conversation in #3200.

pdurbin added a commit that referenced this issue Jul 8, 2016
@pdurbin
Private URL: avoid commands so Contributor can delete draft #3200 #3201
24df280
This was referenced Jul 8, 2016
Merged
Closed
pdurbin added a commit that referenced this issue Jul 13, 2016
@pdurbin
Private URL: duplicate commands so Contributor can delete draft #3200 #…
4f6cc0c 
…3201
@pdurbin
Copy link
Member

pdurbin commented Jul 14, 2016

@scolapasta please see #3200 (comment)

@pdurbin pdurbin assigned scolapasta and unassigned pdurbin Jul 14, 2016
@pdurbin
Copy link
Member

pdurbin commented Jul 14, 2016

@scolapasta and @michbarsinai blessed the fix at 24df280 so I merged it into pull request #3111. Passing to QA.

@pdurbin pdurbin assigned kcondon and unassigned scolapasta Jul 14, 2016
@kcondon
Copy link
Contributor Author

kcondon commented Jul 18, 2016

Works, closing.

@kcondon kcondon closed this as completed Jul 18, 2016
@djbrooke djbrooke assigned pdurbin and unassigned kcondon Jul 26, 2016
@djbrooke djbrooke reopened this Jul 26, 2016
@djbrooke djbrooke added ready and removed ready labels Jul 26, 2016
@pdurbin pdurbin removed their assignment Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Permissions Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
4.5 - Metadata Export and Harvesting
Development

No branches or pull requests
4 participants
@pdurbin @scolapasta @kcondon @djbrooke