Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable copyright footer #3379

Closed
donsizemore opened this issue Sep 23, 2016 · 8 comments
Closed

Allow customizable copyright footer #3379

donsizemore opened this issue Sep 23, 2016 · 8 comments
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@donsizemore
Copy link
Contributor

donsizemore commented Sep 23, 2016

Thu-Mai would like for us to be able to protect the Odum and UNC names and logos, in addition to anything that doesn't have established user terms. This may better be tacked on to issue #2905.

@pdurbin
Copy link
Member

pdurbin commented Sep 23, 2016

#2003 is related and currently has a milestone of 4.6. When @tdilauro visited a few months back he talked about how he tweaked the footer to add information that presumably currently lives in their DVN 3.x instance at https://archive.data.jhu.edu/dvn/ (he also added a Johns Hopkins banner to the top, he said).

@pdurbin
Copy link
Member

pdurbin commented Sep 23, 2016

I made a minimal pull request at #3380 to show the part of the code that needs to change. Docs and tests need to be added.

@pdurbin pdurbin self-assigned this Sep 23, 2016
@pdurbin
Copy link
Member

pdurbin commented Sep 27, 2016

@mheppler and I discussed 242080d this morning and there a few things we'd like to address:

  • Roll in a fix for Footer: Make Copyright Date Dynamic #2905 to make the copyright date dynamic
  • Have "Copyright © 2016, " be system generated but have "The President & Fellows of Harvard College" be configurable.
  • For performance use settingsWrapper.get rather than systemConfig.footerCopyright
  • Document the new setting.

@djbrooke
Copy link
Contributor

@pdurbin @mheppler

May we just do the final bullet and call this done instead of expanding this?

@pdurbin
Copy link
Member

pdurbin commented Sep 27, 2016

I just rolled the dynamic copyright year issue (#2905) into my pull request for this issue (#3380) since they are so closely related. @djbrooke indicated that if the fixes are trivial they could be given a milestone of 4.5.1, which I just did. I also documented the setting in the installation guide.

I didn't address the performance concern. I'm not actually sure if settingsWrapper.get performance stuff is compatible with how I'm doing things. @scolapasta would know.

At https://waffle.io/IQSS/dataverse I'm moving this to QA since I'm happy with the solutions.

@mheppler
Copy link
Contributor

Discussed with @pdurbin and @djbrooke on moving the dynamic copyright features developed as part of this issue, into issue #2905 and send that to QA for 4.5.1.

Then, this issue will remain open for a later release, so that we can gather additional input from other installations on how they'd like to further customize the footer with custom text, images, layout, etc.

@mheppler mheppler removed this from the 4.5.1 - IP Groups fixes milestone Sep 27, 2016
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner and removed Status: QA labels Sep 27, 2016
@mheppler mheppler added this to the 4.5.1 - IP Groups fixes milestone Sep 27, 2016
@mheppler mheppler removed the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Sep 27, 2016
@mheppler mheppler removed this from the 4.5.1 - IP Groups fixes milestone Sep 27, 2016
@pdurbin
Copy link
Member

pdurbin commented Sep 28, 2016

@mheppler sounds fine. I'll unassign myself from this one so anyone can pick it up to work on logos, etc. Pull request #3380 only handles changing the text (so it doesn't have "Harvard" in it).

@pdurbin pdurbin removed their assignment Sep 28, 2016
pdurbin added a commit that referenced this issue Sep 29, 2016
Also use `settingsWrapper.get` for better performance.
@mheppler mheppler added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Oct 10, 2016
@mheppler
Copy link
Contributor

This issue is being closed in favor of a new issue, so that it can be easily tracked through development.

Thank you for your input @donsizemore! Please check those new issues to make sure that we are covering your requested features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

4 participants