Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File > Configure > Privacy Preview -- As a Data Owner, I want to create a differentially private view of my metadata so that anyone can see it #4233

Closed
djbrooke opened this issue Oct 25, 2017 · 18 comments
Closed

File > Configure > Privacy Preview -- As a Data Owner, I want to create a differentially private view of my metadata so that anyone can see it #4233

djbrooke opened this issue Oct 25, 2017 · 18 comments
Assignees
@kcondon
Milestone
4.8.5 - Guestbook...

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Oct 25, 2017 •
edited
Loading

We should allow Data Owners to enable differentially private access for sensitive files that currently cannot be safely shared. This can be considered done even if the researcher cannot explore the differentially private metadata.

https://docs.google.com/presentation/d/1rPpaHNW-5QIskYvn_4afzXzU_wcdkZb2SjEDhpUhhLs/edit#slide=id.g26f2e4bd68_0_36
@djbrooke djbrooke changed the title As a Data Owner, I want to create a differentially private view of my metadata so that researchers can learn about my data before going through the IRB process. As a Data Owner, I want to create a differentially private view of my metadata Oct 25, 2017
@djbrooke djbrooke changed the title As a Data Owner, I want to create a differentially private view of my metadata As a Data Owner, I want to create a differentially private view of my metadata so that anyone can see it Oct 25, 2017
@mheppler
Copy link
Contributor

Reviewed the workflow slides with @TaniaSchlatter this morning and will be adding mockups to this issue upon finalization.

@mheppler
Copy link
Contributor

mheppler commented Oct 31, 2017 •
edited
Loading

NOTE: Backend prerequisite, issue #4230

Here is an outline the proposed UI changes.

UI IMPACT

Dataset pg

  • Configure > Privacy Preview, new "Configure" dropdown button will be added to each tabular file row in file table, and will also include current "Map" option for Geoconnect
  • Privacy-Preserving Data Preview popup, info msg explaining PSI tool, links to PSI with Configure button
  • Warning msg, "manual refresh..."

File pg

  • Configure > Privacy Preview, new "Configure" dropdown button will be added to action button area at top of pg for tabular files
  • Privacy-Preserving Data Preview popup, help msg explaining PSI tool, links to PSI with Configure button
  • Warning msg, "manual refresh..."

NOTE: See issue #4234 for the rest of the workflow, which includes exploring the privacy preview in TwoRavens.

QUESTIONS

  • Is the new Configure button for PSI (and Geoconnect) kosher?
  • Is the Privacy-Preserving Data Preview popup title modular enough compared to the Configure dropdown option text?
  • How do we get a success msg on the pg? Do we need a success msg (if TwoRavens handles the info msg and privacy preview selection)?

MOCKUPS

psi-dataset-configure

psi-privacy-preview-info-msg

psi-dataset-warning

@mheppler mheppler mentioned this issue Nov 2, 2017
Closed
@pdurbin pdurbin mentioned this issue Nov 3, 2017
Closed
@djbrooke djbrooke assigned dlmurphy and unassigned TaniaSchlatter Nov 6, 2017
dlmurphy added a commit that referenced this issue Nov 6, 2017
@dlmurphy
Doc structuring [ref: #4233]
bcf8e49 
Created new page for privacy management features, including file
restrict, DataTags, and PSI. This page will be developed further in
future commits.
dlmurphy added a commit that referenced this issue Nov 6, 2017
@dlmurphy
Fix to doc structure [ref: #4233]
05a6f42 
Fixed hierarchy of sections in this doc.
dlmurphy added a commit that referenced this issue Nov 6, 2017
@dlmurphy
More doc additions [ref: #4233]
511da28 
Rewrote and expanded PSI docs, removed unsightly colons from headers of
Tabular Data Ingest -> CSV doc.
@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2017

@matthew-a-dunlap please use branch 4230-4233-external-tool-psi. I will ping you if I want to re-merge my branch for #4230 into it.

pdurbin added a commit that referenced this issue Nov 7, 2017
@pdurbin
Merge branch '4233-PSI-data-owner' into 4230-4233-external-tool-psi #…
af704fb 
…4233
@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2017

@dlmurphy as we discussed I just merged 4233-PSI-data-owner into 4230-4233-external-tool-psi. I'll delete the former and when you are unblocked on the "TO BE ADDED" items, please use the latter.

@dlmurphy dlmurphy removed their assignment Nov 7, 2017
matthew-a-dunlap added a commit that referenced this issue Nov 7, 2017
@matthew-a-dunlap
Configure button for files in file table. #4233
5519cf3 
Incomplete as of now, url needs to be correct passed to each button. Also button is probably not in correct place in UI
matthew-a-dunlap added a commit that referenced this issue Nov 9, 2017
@matthew-a-dunlap
Configure dropdown in dataset page #4233
5d26270
@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Nov 9, 2017 •
edited
Loading

Question about the modular dropdown:

  • Should we only show the psi tool option to logged in users?
  • If there are no options in the dropdown (for example if the user is not logged in) should we hide the dropdown?

Other questions:

  • Should clicking psi from the pop-up open a new tab instead of directing the current one?
  • If the above is yes, I assume the warning message is then triggered on the dataverse page about refreshing?

@mheppler @TaniaSchlatter

@scolapasta
Copy link
Contributor

Configure options will need to be not just for logged in users, but only if you have edit dataset permission. (As the result of the configure will call apis that edit)

@mheppler
Copy link
Contributor

@matthew-a-dunlap Gustavo should have covered your first two button questions. Yes and yes for your "other questions". I can stop by if you'd like to talk through the workflow in more detail.

matthew-a-dunlap added a commit that referenced this issue Nov 13, 2017
@matthew-a-dunlap
modular conf dataset dropdown and psi popup #4233
c8d3acc 
Popup works from both dataset and files page, populating the correct external url in the button.
matthew-a-dunlap added a commit that referenced this issue Nov 13, 2017
@matthew-a-dunlap
PSI popup notification and code cleanup #4233
d769d9c
@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Nov 21, 2017 •
edited
Loading

Here is the list of code review feedback on the UI side of modular configure:

  • The logic for what tools to show for a file should be moved out of the UI and instead be at creation of the list of handlers for the files.
    • Eventually we will likely add the file to the configurations themselves. At the moment we will only have infrastructure to write back in specific cases (e.g. psi fuzzy summary statistics) so file typing is less important. A comment will be left in the code about this
  • Even if the handler list is well populated, passing the full list up front does not work for the UI from a lazy loading perspective
    • The one issue I (Matthew) see is that the datasetPage generates a giant list of all tools for all files on load of the page. While this is not passed to the UI it may be better to get the individual per-file lists as needed
  • Make sure popup matches map logic on when to show buttons when dataverse is a widget (e.g. shown in an iframe)

matthew-a-dunlap added a commit that referenced this issue Nov 21, 2017
@matthew-a-dunlap
external tool type checks moved to find methods, and clean up #4233
fad28bd
matthew-a-dunlap added a commit that referenced this issue Nov 21, 2017
@matthew-a-dunlap
Dataset page gets file-based externalTool lists as needed, not for al…
b4578ac 
…l files upfront #4233
matthew-a-dunlap added a commit that referenced this issue Nov 21, 2017
@matthew-a-dunlap
configure popup should not show up in widgetView #4233
f954a2f
matthew-a-dunlap added a commit that referenced this issue Nov 21, 2017
@matthew-a-dunlap
Access ExternalTools for a file more directly #4233
228ad86 
A few tests are still broken, will fix in next commit
matthew-a-dunlap added a commit that referenced this issue Nov 22, 2017
@matthew-a-dunlap
Fixed configure unit test #4233
bc7736e
matthew-a-dunlap added a commit that referenced this issue Nov 22, 2017
@matthew-a-dunlap
Code cleanup and comments #4233
9eb80c2
matthew-a-dunlap added a commit that referenced this issue Nov 22, 2017
@matthew-a-dunlap
More comment cleaning #4233
e2f27d6
matthew-a-dunlap added a commit that referenced this issue Nov 22, 2017
@matthew-a-dunlap
code breaking accidental character #4233
c8d8adc
@matthew-a-dunlap matthew-a-dunlap removed their assignment Nov 27, 2017
@scolapasta scolapasta self-assigned this Nov 27, 2017
@dlmurphy dlmurphy self-assigned this Nov 27, 2017
dlmurphy added a commit that referenced this issue Nov 27, 2017
@dlmurphy
Remove Privacy Management doc [#4233]
ca7ab99 
Per discussion with @scolapasta, temporarily removing Privacy Management
page from user guide since this branch is only for the PSI demo. Page
will be reinstated on a DataTags branch.
@dlmurphy dlmurphy removed their assignment Nov 27, 2017
@djbrooke djbrooke mentioned this issue Nov 27, 2017
Closed
matthew-a-dunlap added a commit that referenced this issue Nov 27, 2017
@matthew-a-dunlap
code review #4233
ec12fc9 
- store repeatedly created variables
- remove psi.json
matthew-a-dunlap added a commit that referenced this issue Nov 27, 2017
@matthew-a-dunlap
More token cleanup and a comment #4230 #4233
344a77d
@kcondon kcondon self-assigned this Nov 29, 2017
pdurbin added a commit that referenced this issue Dec 5, 2017
@pdurbin
Merge branch 'develop' into 4230-4233-external-tool-psi #4230 #4233
8b9e125
@kcondon kcondon closed this as completed Dec 7, 2017
@kcondon kcondon removed the Status: QA label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.8.5 - Guestbook and IP Groups fixes
Development

No branches or pull requests
9 participants
@pdurbin @mheppler @sekmiller @scolapasta @kcondon @djbrooke @matthew-a-dunlap @TaniaSchlatter @dlmurphy