Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Errors not showing at Dataset Field Level #6380

Closed
sekmiller opened this issue Nov 18, 2019 · 5 comments · Fixed by #6382
Closed

Validation Errors not showing at Dataset Field Level #6380

sekmiller opened this issue Nov 18, 2019 · 5 comments · Fixed by #6382
Assignees
Labels
Type: Bug a defect
Milestone

Comments

@sekmiller
Copy link
Contributor

When creating/editing a Dataset if required fields are left blank a message appears at the top of the form and should also appear at each individual field that fails validation. The field level error messages are missing in the current Develop branch.

@sekmiller
Copy link
Contributor Author

sekmiller commented Nov 18, 2019

Screen Shot 2019-11-18 at 10 43 58 AM

Expected behavior on demo (v. 4.17 build 1450-51739f6)...

Screen Shot 2019-11-19 at 7 02 18 PM

@kcondon
Copy link
Contributor

kcondon commented Nov 18, 2019

Confirmed this also happens in 4.18 but not in 4.17

@pdurbin pdurbin added the Type: Bug a defect label Nov 18, 2019
@sekmiller sekmiller self-assigned this Nov 19, 2019
@sekmiller
Copy link
Contributor Author

Field level error messages are showing up in this commit from 10/16:

https://github.com/IQSS/dataverse/tree/8d695705c62aa2cf946a68d0d58f03ba48fed93f

Accessibilty changes to the dataset page started on 10/17.

@sekmiller
Copy link
Contributor Author

The first commit where it doesn't work is

695a5c1

@mheppler
Copy link
Contributor

mheppler commented Nov 20, 2019

To fix the inline validation msgs, reverted required attributes added to input fields on the metadataFragment and datasetFieldForEditFragment, as well as restored the pt:aria-required attributes that appear to be tied into the validation msg display issues, but I can not determined how or why.

Also fixed the validation msg styling issues for some fields in metadataFragment that had bold message text, while the others were normal message text.

Screen Shot 2019-11-19 at 8 14 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants