Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow S3 direct uploads with checksum algorithms other than MD5 #7600

Closed
qqmyers opened this issue Feb 10, 2021 · 0 comments · Fixed by #7602
Closed

Allow S3 direct uploads with checksum algorithms other than MD5 #7600

qqmyers opened this issue Feb 10, 2021 · 0 comments · Fixed by #7602
Labels
GDCC: DANS related to GDCC work for DANS

Comments

@qqmyers
Copy link
Member

qqmyers commented Feb 10, 2021

Dataverse itself supports several checksum algorithms in addition to MD5, but the initial S3 direct upload API implementation hardcoded the algorithm to md5 (partly for simplicity and partly because md5 would be quicker to compute for large files).

DANS is now planning to use the API to migrate datafiles where they are computing/have computed SHA-1 hashes. Given the underlying support in Dataverse for SHA-1, removing the limitation of the api is straight-forward. I'll submit a PR that maintains backward compatibility and update documentation in #7596 to match.

@qqmyers qqmyers added the GDCC: DANS related to GDCC work for DANS label Feb 10, 2021
qqmyers added a commit to GlobalDataverseCommunityConsortium/dataverse that referenced this issue Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: DANS related to GDCC work for DANS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant