Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not support protocol "http" on method reassignIdentifierAsGlobalId #7808

Closed
Esteban-Mtz opened this issue Apr 16, 2021 · 3 comments · Fixed by #8665
Closed

Not support protocol "http" on method reassignIdentifierAsGlobalId #7808

Esteban-Mtz opened this issue Apr 16, 2021 · 3 comments · Fixed by #8665
Milestone
5.12

Comments

@Esteban-Mtz
Copy link
Contributor

In class ImportGenericServiceBean.java on method reassignIdentifierAsGlobalId line 428, you only check if identifierString starts with "GlobalId.HDL_RESOLVER_URL" or "GlobalId.DOI_RESOLVER_URL" in line 433.

Those strings are "GlobalId.HDL_RESOLVER_URL" = "https://hdl.handle.net/" and "GlobalId.DOI_RESOLVER_URL" = "https://doi.org/" respectively. In case identifierString starts with http ("http://hdl.handle.net/"), the object will not be processing.

Best Regards.
@djbrooke
Copy link
Contributor

Hi @Esteban-Mtz - are you interested in making a pull request for this?

@Esteban-Mtz
Copy link
Contributor Author

Ok @djbrooke.

@Esteban-Mtz Esteban-Mtz mentioned this issue Apr 29, 2022
Merged
@mreekie
Copy link

mreekie commented May 25, 2022 •
edited
Loading

pdurbin added a commit to Esteban-Mtz/dataverse that referenced this issue Jun 7, 2022
@pdurbin
Merge branch 'develop' into 7808-support-protocol-http IQSS#7808
7e9a5c9
pdurbin added a commit to Esteban-Mtz/dataverse that referenced this issue Jun 8, 2022
@pdurbin
add tests IQSS#7808
1f3ec4a
pdurbin added a commit to Esteban-Mtz/dataverse that referenced this issue Jul 13, 2022
@pdurbin
Merge branch 'develop' into 7808-support-protocol-http IQSS#7808
fc19d40
@pdurbin pdurbin added this to the 5.12 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.12
Development

Successfully merging a pull request may close this issue.

Fix support protocol http import OAI_DC Esteban-Mtz/dataverse
4 participants
@pdurbin @djbrooke @mreekie @Esteban-Mtz