Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Get the existing ROR plug-in working on the dataverse demo #9151

Closed
2 of 3 tasks
mreekie opened this issue Nov 8, 2022 · 18 comments
Closed
2 of 3 tasks

Epic: Get the existing ROR plug-in working on the dataverse demo #9151

mreekie opened this issue Nov 8, 2022 · 18 comments
Assignees
Labels
D: 5 Core PIDs Deliverable Increment defining how we support the 5 core PIDs NIH OTA: 1.2.1 2 | 1.2.1 | Design and implement integration with controlled vocabularies | 5 prdOwnThis is an it... pm.GREI-d-1.2.1 NIH, yr1, aim2, task1: Design and implement integration with controlled voc Size: 80 A percentage of a sprint. 56 hours. Type: Suggestion an idea

Comments

@mreekie
Copy link

mreekie commented Nov 8, 2022

This script completes a single field on a form. Author affiliation

definition of done:

  • If it acts as intended, in particular the last time it broke other pages, the we can call this complete.
  • If it works well, we can put it out on demo.
  • Make a recommendation as to if it can go into production
    • If this is the case this will lead to a separate issue to move the script into production
@mreekie
Copy link
Author

mreekie commented Jan 10, 2023

priority discussion with Stefano;

  • Size this.
  • If it's not overly large, get it to the top of the sprint ready backlog
  • Moved from NIH Deliverables Backlog to Ordered Backlog

@mreekie
Copy link
Author

mreekie commented Jan 11, 2023

Top priority for upcoming sprint

@mreekie
Copy link
Author

mreekie commented Jan 11, 2023

sizing:

  • discussion is in the description
  • size: 3

@mreekie mreekie added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 11, 2023
@sekmiller sekmiller self-assigned this Jan 19, 2023
@mreekie
Copy link
Author

mreekie commented Jan 23, 2023

sprint:

  • Steve, Jim working through a blocker.
  • Notes in slack

@mreekie
Copy link
Author

mreekie commented Jan 25, 2023

Resizing for next sprint

  • The original operating assumption was that what we started with was working. It's not.
  • This makes the size grow.
  • The original devs indicated that they understand that it's broken and we don't think that we can depend on them for fixed code.
  • Part of what we will need to do is get into the controlled vocabulary. There is "first time" cost to this one.
  • sizing at: 80

@mreekie mreekie added Size: 80 A percentage of a sprint. 56 hours. and removed Size: 3 A percentage of a sprint. 2.1 hours. labels Jan 25, 2023
@sekmiller sekmiller removed their assignment Jan 26, 2023
@sekmiller sekmiller self-assigned this Jan 31, 2023
@mreekie
Copy link
Author

mreekie commented Feb 7, 2023

Monthly update review

bump: @sekmiller

Steve, would it be possible to drop some breadcrumbs on this in such a way that my 5th grader brain can process them?
The context is that I'm working on the monthly update

Here's my shot at it. Lemme know if it's accurate.

In this issue we installing a script for pulling down the Author affiliation field from the Research Organization Registry (ROR) in our demo dataverse. This previously ran and it represents a new lightweight way of retrieving this information and having more control over the user experience.

The feature no longer works out of the box as of 5.12 and so the scope of work has expanded to understanding what we need to do to get this working.

I'm unsure of whether the info that follows is within the expanded scope of this issue or will be in additional issues:

Coming out of our meeting on the topic of PIDs we decided that our initial level of support for ROR will include:

  • The UI displaying information that is easily interpreted by the user
  • The updating of the database with the data.
    • I don't recall that we agreed on anything further than what is done already in the existing ROR plug-in terms of what data will be stored to the database.
  • Once it's working we'll get it out on demo.
  • Then Make a recommendation as to if it can go into production
    • If this is the case this will lead to a separate issue to move the script into production

@mreekie mreekie added the D: 5 Core PIDs Deliverable Increment defining how we support the 5 core PIDs label Feb 7, 2023
@mreekie
Copy link
Author

mreekie commented Feb 8, 2023

sprint sizing:

  • no change
  • Still discovering

@pdurbin
Copy link
Member

pdurbin commented Mar 1, 2023

As discussed at the sprint kickoff just now 🏈 🏈 🏈 the backend code for this issue is dependent on this (currently draft) PR by @qqmyers:

@qqmyers
Copy link
Member

qqmyers commented Mar 13, 2023

See #9150 (comment) for info on an implementation mirroring the FundReg and ORCID scripts.

@mreekie
Copy link
Author

mreekie commented Mar 14, 2023

See #9150 (comment) for info on an implementation mirroring the FundReg and ORCID scripts.

Daily

@mreekie mreekie added the pm.GREI-d-1.2.1 NIH, yr1, aim2, task1: Design and implement integration with controlled voc label Mar 20, 2023
@cmbz
Copy link

cmbz commented Jun 1, 2023

Question for @qqmyers and @pdurbin:

Is this NIH GREI deliverable (1.2.1) complete?

@qqmyers
Copy link
Member

qqmyers commented Jun 1, 2023

#12 is obsolete and refers to the example that existed before #9150. Before the deliverable is complete, there are a few things to do:

  • Merge #14
  • perform some review/QA of the overall changes to Dataverse (Create a javascript for the frontend that supports Fundref #9150) with the new JavaScript (#14) w.r.t. the goals of the deliverable - could be done before or after #14 is merged
  • fix any issues required to meet the goals for the deliverable (one potential issue is that the ror service can be slow and someone could decide that running our own copy is required to make things fast enough for production deployment)
  • deploy where desired for the deliverable - which field(s) and whether this is to demo or dataverse.harvard.edu

These steps are somewhat generic and probably apply to FundReg and to ORCID as well (at least the parts related to the external vocab/lookup of people at the ORCID service).

@cmbz
Copy link

cmbz commented Dec 18, 2023

2023/12/18

@qqmyers
Copy link
Member

qqmyers commented Dec 18, 2023

FWIW: The "just work" issue is out-of-date, which is why ROR works on demo.dataverse.org - #9402 was added to v5.14 and the scripts were updated in gdcc/dataverse-external-vocab-support#14. Whether the way it works on demo is good-enough to use in production or if further work is desired is a reasonable question, but if it is acceptable as a start, it's a size3 to put it on Harvard.

@jggautier
Copy link
Contributor

jggautier commented Dec 18, 2023

Ah thanks. I was just about to ask about the "just work" issue. Should I just close gdcc/dataverse-external-vocab-support#12 then? @pdurbin what do you think?

About determining if the way it works on demo is good enough, I think we've heard a bit from the ROR folks about best practices for using ROR that we could consider. We could do usability testing to determine how much of those best practices we should be following before we apply these changes to the Author Affiliation field in Harvard Dataverse.

And I have questions about how this affects several metadata exports, based on a quick review of the exports in Demo Dataverse, but I could start documenting those so they can be reviewed and worked on later if needed. If we did this, I would be concerned about us not finding the bandwidth to improve this later, similar to other issues where Dataverse exports were improved but extra steps are needed to apply those improvements to datasets that have already been published in Dataverse repositories, e.g. IQSS/dataverse.harvard.edu#222 and IQSS/dataverse.harvard.edu#146

@pdurbin
Copy link
Member

pdurbin commented Dec 18, 2023

@jggautier good catch. I just closed gdcc/dataverse-external-vocab-support#12 in favor of this one.

@jggautier
Copy link
Contributor

jggautier commented Mar 13, 2024

Thanks @pdurbin.

As discussed during today's Dataverse monthly meeting, the next step could be to evaluate the implementation and recommend more next steps.

We could do the following:

  • Compare the change to the Author Affiliation field on Demo Dataverse - which includes a type ahead that makes suggestions from ROR's database - and ROR's best practices for using ROR. This could be a heuristic evaluation, where we ask ourselves how the current implementation does and does not follow ROR's best practices.
  • Open issues about how the implementation affects how Author metadata is included in Dataverse's metadata exports and how it should be included

But ROR can be used to help users add other types of information, like:

  • the names of authors that are organizations and the names of other types of contributors that are organizations (including "distributors", "producers" and funders)
  • and the affiliations of authors and of other types of contributors that are people

So while it'll be helpful to evaluate at how ROR is implemented for just this Author Affiliation field, if we make any changes to how ROR is implemented for just this Author Affiliation field, apply those changes to Harvard Dataverse, and encourage other installations to do the same, we risk needing to re-evaluate those changes once we're able to consider the use of ROR and other external controlled vocabularies, like ORCID, across all of the metadata fields that Dataverse ships with, which is part of what IQSS/dataverse.harvard.edu#230 is about. That work should involve considering larger changes, such as potential re-designs to the metadata model and the forms in the UI.

So I'm recommending that we:

  • Evaluate the change to the Author Affiliation field on Demo Dataverse, comparing it to ROR's best practices
  • Not apply this ROR implementation to the Author Affiliation field in Harvard Dataverse but instead...
  • Document that evaluation so that we can build on it as we're looking at the use of ROR and other controlled vocabularies, like ORCID, across all of the metadata fields that Dataverse ships with

@jggautier
Copy link
Contributor

We'll close this issue and open a new issue for what I recommended in my earlier comment about evaluating what's been put on Demo Dataverse and building on that evaluation as we're looking at the use of ROR and other controlled vocabularies, like ORCID, across all of the metadata fields that Dataverse ships with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: 5 Core PIDs Deliverable Increment defining how we support the 5 core PIDs NIH OTA: 1.2.1 2 | 1.2.1 | Design and implement integration with controlled vocabularies | 5 prdOwnThis is an it... pm.GREI-d-1.2.1 NIH, yr1, aim2, task1: Design and implement integration with controlled voc Size: 80 A percentage of a sprint. 56 hours. Type: Suggestion an idea
Projects
Status: No status
Development

No branches or pull requests

6 participants