Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Shibboleth code as ShibAuthenticationProvider #963

Closed
pdurbin opened this issue Oct 16, 2014 · 5 comments
Closed

Refactor Shibboleth code as ShibAuthenticationProvider #963

pdurbin opened this issue Oct 16, 2014 · 5 comments
Assignees
@michbarsinai
Milestone
Beta 13 - Dataver...

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 16, 2014

As of this writing the Shibboleth logic is here: https://github.com/IQSS/dataverse/blob/master/src/main/java/edu/harvard/iq/dataverse/Shib.java

It should be refactored so we actually implement a ShibAuthenticationProvider: https://github.com/IQSS/dataverse/blob/master/src/main/java/edu/harvard/iq/dataverse/authorization/providers/shib/ShibAuthenticationProvider.java

I have questions for @michbarsinai about fitting what I've done into the model so I'm going to give this ticket to him for now to review what I've done. It sounds like he'd like to work on #954 first.

Also, so this doesn't fall through the cracks, every time a user logs in with Shib, we should update the AuthenticatedUser table with the latest info for that user.
@pdurbin pdurbin added this to the In Review - Dataverse 4.0 milestone Oct 16, 2014
@pdurbin pdurbin mentioned this issue Oct 20, 2014
Closed
@michbarsinai
Copy link
Member

@pdurbin: We need to discuss online (skype/hangout). Meanwhile, where can I see this in action?

@pdurbin
Copy link
Member Author

pdurbin commented Oct 21, 2014

We need to discuss online (skype/hangout). Meanwhile, where can I see this in action?

@michbarsinai you can try it at https://dataverse-demo.iq.harvard.edu as explained (with screenshots) in a great post by @posixeleni at http://datascience.iq.harvard.edu/blog/try-out-single-sign-shibboleth-40-beta

@pdurbin pdurbin modified the milestones: Beta 9 - Dataverse 4.0, In Review - Dataverse 4.0 Nov 4, 2014
pdurbin added a commit that referenced this issue Nov 10, 2014
@pdurbin
started refactoring Shib code #963
d8fd790
@scolapasta scolapasta modified the milestones: Beta 11 - Dataverse 4.0, Dataverse 4.0: Final, TEMP, Beta 13 - Dataverse 4.0 Jan 23, 2015
pdurbin added a commit that referenced this issue Jan 28, 2015
@pdurbin
Shib: update authUser displayInfo every login #963
ad629e4 
Also, provide two dev modes: contant and random.
@pdurbin
Copy link
Member Author

pdurbin commented Jan 28, 2015

Also, so this doesn't fall through the cracks, every time a user logs in with Shib, we should update the AuthenticatedUser table with the latest info for that user.

Mentioned in Shib FRD and done in ad629e4

@pdurbin pdurbin mentioned this issue Jan 30, 2015
Closed
@scolapasta
Copy link
Contributor

Discussed with @pdurbin and @michbarsinai and we decided that we don't think we need this.

Closing ticket and there is nothing to test (it was a code related issue).

@michbarsinai
Copy link
Member

Re-opening, after talking with @pdurbin about this. This bag should be worked on after #3338 is implemented and merged.

pdurbin added a commit that referenced this issue Dec 16, 2016
@pdurbin
integrate Shibbleth into AuthenticationProviderRow #3338 #3410 #963
546ae73 
- No more :ShibEnabled config option, use standard JSON loading instead.
- Obviate need for systemConfig.isShibEnabled()
- Deprecate the "echo" examples.
- Many related installation guide updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michbarsinai michbarsinai

Labels
None yet
Projects
None yet
Milestone
Beta 13 - Dataverse 4.0
Development

No branches or pull requests
4 participants
@pdurbin @michbarsinai @scolapasta @eaquigley