#9949 missing deployment Fix #10094
Merged
#9949 missing deployment Fix #10094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these will run on docker.
Windows caused by a race condition due the database not being ready when the DV container started.
pdurbin
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
I watched @jp-tosca test this with @poikilotherm . Great fix. Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On the first launch DV would not be deployed on Windows due a race condition the database was not ready and fail sequential operations between containers.
Which issue(s) this PR closes:
#9949
Closes #9949
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
n/a
Is there a release notes update needed for this change?:
n/a
Additional documentation:
n/a