Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10466: quick fix for math challenge contact form on 403 error page #10602

Merged

Conversation

jeromeroucou
Copy link
Contributor

What this PR does / why we need it:

If a user wishes to access a page, but is prevented from doing so by a rights issue (ACL), the error message on page 403 indicates this. Actually, the form can no longer be submitted because the mathematical challenge is empty. This PR corrects this and makes it possible to submit this form again.

Which issue(s) this PR closes:

Closes #10466

Special notes for your reviewer:

I do a simple quick fix, I don't understand why the SendFeedbackDialog.initUserInput method isn't called. But with the new SPA interface, this bug will disappear, as it's linked to the current JSF view (view from MVC). So it seems to me that this is acceptable.

Suggestions on how to test this:

I use this test case to validate this PR :

  • I login into a repository with a account A
  • I create a collection and publish them
  • Into this dataverse, I create a dataset in draft status
  • I copy the URL of the dataset
  • I logout and re-sigin with a another account B
  • I try to access to the dataset previously created
  • On the 403 page (forbidden access), I open the contact form to verify if the math challenge is now print

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No change

Is there a release notes update needed for this change?:

I don't think because the contact form on forbidden access page is a small functionality. But if needed I can write them.

Additional documentation:

No

qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this pull request May 31, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the fix at QDR and it appears to work/ shows a valid math problem.

Note that the IT tests didn't run due to some problem launching the ec2 instance - presumably not related.

@qqmyers qqmyers added the Size: 0.5 A percentage of a sprint. 0.35 hours label Jun 1, 2024
@pdurbin
Copy link
Member

pdurbin commented Jun 3, 2024

@cmbz @scolapasta can we prioritize this one?

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but it looks promising. Approved.

@stevenwinship stevenwinship self-assigned this Jun 10, 2024
@stevenwinship stevenwinship merged commit e7a0e37 into IQSS:develop Jun 10, 2024
10 of 11 checks passed
@stevenwinship stevenwinship removed their assignment Jun 10, 2024
@pdurbin pdurbin added this to the 6.3 milestone Jun 10, 2024
luddaniel pushed a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Jun 12, 2024
@luddaniel luddaniel deleted the 10466-fix_match_challenge_403 branch September 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captcha question in contact form doesn't appear on 403 error page
4 participants