wait for Dataverse to be ready (sleep a bit) before executing ./setup-all.sh #10766
+37
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added
Component: Code Infrastructure
pdurbin
reviewed
Sep 27, 2024
There was a problem hiding this comment.
I left a comment but more importantly, we should decide if we want this or not. @landreev wrote install.py so I'd like to hear what he thinks.
Also, I'm not sure if this is worth a release note snippet or not. I don't mind too much that there isn't one.
Comment on lines
+553
to
558
|
|
||
| time.sleep(20) # wait for the deployment to complete | ||
|
|
||
| # @todo: find a better way to wait for the deployment to complete rather than just sleeping | ||
| # @todo: restart/try to deploy again if it failed? | ||
| # @todo: if asadmin deploy says it was successful, verify that the application is running... if not - repeat the above? |
There was a problem hiding this comment.
I think it would make more sense to have the sleep AFTER the todo's.
pdurbin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reduce the chance of blank page (404 error) after a fresh install by
install.pyWhich issue(s) this PR closes:
This is not a solid fix but a quick workaround to reduce the chance of such error, related issues are:
Special notes for your reviewer:
Replace the time.sleep if you know a better way to check the status of dataverse.
Suggestions on how to test this:
Run fresh installation process.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No