Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE using CVOC #10870

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

luddaniel
Copy link
Contributor

What this PR does / why we need it:

Fixes a possible NullPointerException that prevents the proper indexing of a dataset.

Which issue(s) this PR closes:

Closes #10869

Suggestions on how to test this:

Play around :CVocConf and having multiple configuration activated like SKOMOS + ORCID

Does this PR introduce a user interface change?:

No

Is there a release notes update needed for this change?:

I don't think

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. - Please add a one line release note, e.g. - This release fixes a bug in the external controlled vocabulary mechanism (introduced in v6.3) that could cause indexing to fail when a script is configured for one child field and no other child fields were managed.

FWIW: I didn't see this error using ORCID and ROR for the author field (requiring #10712) because the NPE is avoided due to the ORCID script registering to manage the other fields. - not sure if that provides a way to work-around in 6.3 or not, i.e. by adding a fake registration for a second (empty, missing?) script that would include the managed fields.

@qqmyers qqmyers added the Size: 0.5 A percentage of a sprint. 0.35 hours label Sep 23, 2024
@scolapasta scolapasta added this to the 6.4 milestone Sep 23, 2024
@pdurbin pdurbin merged commit 2bdc7b3 into IQSS:develop Sep 23, 2024
11 checks passed
@luddaniel luddaniel deleted the 10869-fix-cvoc-npe branch October 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
Status: Done 🧹
Status: 🚀 Done (Recherche Data Gouv)
Development

Successfully merging this pull request may close these issues.

6.3 : Indexing issue while using CVOC setting
4 participants