Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor superuser API endpoint to migrate Shib user to builtin/local account #3120

Merged
merged 2 commits into from
May 17, 2016

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented May 16, 2016

I had coder's remorse over the quality of work I put into the superuser API endpoint to migrate Shib user to builtin/local account in #2915 and confessed to @scolapasta at #3025 (comment) . We agreed that the code should be refactored, which I did in this pull request. Nothing changes in terms of how the API works. Docs at http://guides.dataverse.org/en/2939-shib/installation/shibboleth.html#converting-shibboleth-users-to-local are still accurate. The code was cleaned up and centralized, which means it will be easier to build a GUI around this feature in the future. I'm reopening #2915 since it hasn't shipped yet.

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 5.145% when pulling cd2b9cc on 2915-shib2builtin into 7fe7040 on develop.

@scolapasta scolapasta added this to the 4.4 milestone May 16, 2016
@kcondon kcondon assigned scolapasta and unassigned kcondon May 16, 2016
@kcondon
Copy link
Contributor

kcondon commented May 16, 2016

OK to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants