3358 api cleanup #3381
Merged
3358 api cleanup #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spec. Code cleanup
…for Dataverses resource class.
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/api/Groups.java # src/main/java/edu/harvard/iq/dataverse/authorization/groups/impl/ipaddre ss/IpGroup.java
Closed
Conflicts: src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java Just imports and whitespace.
…patibility, Guide updates.
pdurbin
requested changes
Oct 19, 2016
There was a problem hiding this comment.
@michbarsinai can you please list #3209 in your pull request (#3381)? And any other issues the pull request addresses. There's also magic "Connects to" syntax at the bottom that should be updated to that issues are associated with pull requests at https://waffle.io/IQSS/dataverse
scolapasta
approved these changes
Oct 21, 2016
Because right now we are scaring the poor sysadmins unnecessarily: http://guides.dataverse.org/en/4.4/installation/config.html#blocking-api-endpoints says, "There is a “test” API endpoint used for development and troubleshooting that has some potentially dangerous methods." |
Also, blocking the "admin" API is more than a good idea. It's essential. Fixed the wording.
pdurbin
added this to the 4.6 - File Page, Harvesting Enhancements, Upload Enhancements milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFI Checklist
Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.
1. Related Issues
/api/testendpoint2. Pull Request Checklist
3. Review Checklist
After the pull request has been submitted, fill out this section.
connects to #3358
connects to #3209
connects to #3250
connects to #3235