Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility script to clear EJB timer info (in case of problems during up… #3670

Merged
merged 2 commits into from
Mar 7, 2017

Conversation

pameyer
Copy link
Contributor

@pameyer pameyer commented Mar 6, 2017

…grade/deployment)

RFI Checklist

#3669

1. Related Issues

List and link to the issues in this Pull Request.

  • [#### + Title HERE]

2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Connects to #3669

@coveralls
Copy link

Coverage Status

Coverage remained the same at 9.601% when pulling 1e795e3 on pameyer:exp_clear_timer_util into 603bd0c on IQSS:develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than assuming that glassfish isn't running, I would add an explicit stop - $GLASSFISH_DIR/bin/asadmin stop-domain ...
and maybe a start-domain at the end of the script.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 9.601% when pulling bbb67be on pameyer:exp_clear_timer_util into 603bd0c on IQSS:develop.

@landreev landreev merged commit c3a7e18 into IQSS:develop Mar 7, 2017
@pdurbin pdurbin added this to the 4.6.1 - ORCID and File Replace milestone Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants