Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4896 junit tests #4968

Closed
wants to merge 8 commits into from
Closed

4896 junit tests #4968

wants to merge 8 commits into from

Conversation

benjamin-martinez
Copy link
Contributor

@benjamin-martinez benjamin-martinez commented Aug 16, 2018

connects to #4896

@coveralls
Copy link

coveralls commented Aug 16, 2018

Coverage Status

Coverage decreased (-0.2%) to 15.214% when pulling 79c54a7 on 4896-junit-tests into c53ef2a on develop.

@matthew-a-dunlap
Copy link
Contributor

@benjamin-martinez Did you look into using exclude groups for maven? Probably is better than having a category for Essential Tests that folks need to remember to add or the test won't be run: https://github.com/junit-team/junit4/wiki/categories#using-categories-with-maven

@pameyer
Copy link
Contributor

pameyer commented Aug 20, 2018

@benjamin-martinez with 75ab1fe, using ./conf/docker-aio/run-test-suite.sh fails with:
[INFO] --- maven-surefire-plugin:2.22.0:test (default-test) @ dataverse --- [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] [INFO] Results: [INFO] [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 50.816 s [INFO] Finished at: 2018-08-20T10:45:52-04:00 [INFO] Final Memory: 60M/805M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on project dataverse: No tests were executed! (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

…egory(NonEssentialTests.class) tag is needed when specidying a junit test that shouldn't run every clean and build. #4896
@djbrooke
Copy link
Contributor

@benjamin-martinez do the most recent commits cover @pameyer's feedback?

@pameyer
Copy link
Contributor

pameyer commented Aug 21, 2018

@djbrooke Looks good as of 79c54a7.

@pdurbin
Copy link
Member

pdurbin commented Aug 23, 2018

We merged pull request #4989 instead. Closing.

@pdurbin pdurbin closed this Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants