-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5085 Fix Failing Test related to LinkDataset API #5088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sort of wondering if the behavior changed between what's in production and what's in develop. Now you have to publish before you can link? Before you didn't?
Response publishTargetDataverse = UtilIT.publishDataverseViaNativeApi(dataverseAlias, apiToken); | ||
publishTargetDataverse.prettyPrint(); | ||
publishTargetDataverse.then().assertThat() | ||
.statusCode(OK.getStatusCode()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to fix the indentation above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
@@ -1436,7 +1443,7 @@ public void testCreateDeleteDatasetLink() { | |||
createDataverseResponse = UtilIT.createRandomDataverse(apiToken); | |||
createDataverseResponse.prettyPrint(); | |||
dataverseAlias = UtilIT.getAliasFromResponse(createDataverseResponse); | |||
|
|||
publishTargetDataverse = UtilIT.publishDataverseViaNativeApi(dataverseAlias, apiToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to assert that the status code is "OK" or whatever it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good as of 3ad5e4b
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist