IQSS-5122 Fix NetBeans handling of test files. #5127
Conversation
…he argLine stuff from IQSS#4988 to a property.
| <excludedGroups>${testsToExclude}</excludedGroups> | ||
| <argLine>${argLine} -Duser.timezone=${project.timezone} -Dfile.encoding=${project.build.sourceEncoding} -Duser.language=${project.language} -Duser.region=${project.region}</argLine> | ||
| <!-- testsToExclude come from the profile--> | ||
| <excludedGroups>${testsToExclude}</excludedGroups> |
There was a problem hiding this comment.
Thanks for fixing the indentation here.
There was a problem hiding this comment.
I was in the area, you know... 😄
There was a problem hiding this comment.
I have this dream that bit by bit the code will conform to our house style if we all fix up the lines we're touching. This is probably naive of me. 😄
|
@poikilotherm thanks for discussing the "connects to" thing at http://irclog.iq.harvard.edu/dataverse/2018-10-02 with me. I edited the description so there's only one connects to. The reason for this is that with multiple "connects to" lines, it's confusing for QA to know which pull request to build and test. For example, here's how the sitemap card looked at https://waffle.io/IQSS/dataverse before I removed the extra "connects to" lines:
|
By moving the
argLineinto<properties>, JaCoCo is happy, Maven is happy, Netbeans is happy and IDEA too. 🎉 🎂 🎈I tested all unit test and integration tests. There are test failures with IT tests, but these are just the same as
developbranch has right now, thus unrelated to the change.Please merge ASAP to make @pdurbin and potentially others happy 😄
Related Issues
Pull Request Checklist