Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5850 bagit export2 local fs #5984

Merged
merged 7 commits into from
Jul 10, 2019

Conversation

donsizemore
Copy link
Contributor

@donsizemore donsizemore commented Jul 1, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rst needs a little work. I'll add some screenshots in a bit.

@pdurbin
Copy link
Member

pdurbin commented Jul 1, 2019

Overall, this seems like a very cool feature and nothing jumped out at me as wrong from a quick look at the code.

I have a little feedback on the docs.

Can "BagIt Export" have some sub-items in the table of contents? Here's how it looks right now:

Screen Shot 2019-07-01 at 10 44 06 AM

This looks strange:

Screen Shot 2019-07-01 at 10 44 23 AM

Finally, I think it might be worth clarifying early in the doc that you have to pick between one of two archivers. You can't run both at the same time. That's my understanding anyway. 😄

@pdurbin pdurbin assigned pdurbin and unassigned donsizemore Jul 1, 2019
@pdurbin
Copy link
Member

pdurbin commented Jul 1, 2019

@donsizemore once I got in there it made more sense to add additional headings, I think:

Screen Shot 2019-07-01 at 1 05 07 PM

That was in f7fe5e4 . Please feel free to hack on it a little more if I made things worse. 😄 As long as you're done before QA returns next week. 😄 I'll go ahead and move it over.

@pdurbin pdurbin removed their assignment Jul 1, 2019
@donsizemore
Copy link
Contributor Author

if phil's happy, i'm happy!

@kcondon kcondon self-assigned this Jul 9, 2019
@kcondon
Copy link
Contributor

kcondon commented Jul 10, 2019

@donsizemore Would you update from develop? This is still using the 4.14 version. Thanks!

@donsizemore
Copy link
Contributor Author

@kcondon done. thank you!

@kcondon
Copy link
Contributor

kcondon commented Jul 10, 2019

@donsizemore I'm still seeing v4.14. Is that what you're seeing?

@donsizemore
Copy link
Contributor Author

@kcondon sorry, i need more coffee. how about now?

@kcondon
Copy link
Contributor

kcondon commented Jul 10, 2019

@donsizemore Just had some coffee myself. That did it, thanks!

@kcondon
Copy link
Contributor

kcondon commented Jul 10, 2019

Tested, works. Ready for merge.

@kcondon kcondon merged commit 13533e0 into IQSS:develop Jul 10, 2019
@pdurbin pdurbin added this to the 4.15.1 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow BagIT API to export to a local filesystem
4 participants