-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5850 bagit export2 local fs #5984
Conversation
Local BagIt Archive Command Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rst needs a little work. I'll add some screenshots in a bit.
Overall, this seems like a very cool feature and nothing jumped out at me as wrong from a quick look at the code. I have a little feedback on the docs. Can "BagIt Export" have some sub-items in the table of contents? Here's how it looks right now: This looks strange: Finally, I think it might be worth clarifying early in the doc that you have to pick between one of two archivers. You can't run both at the same time. That's my understanding anyway. 😄 |
@donsizemore once I got in there it made more sense to add additional headings, I think: That was in f7fe5e4 . Please feel free to hack on it a little more if I made things worse. 😄 As long as you're done before QA returns next week. 😄 I'll go ahead and move it over. |
if phil's happy, i'm happy! |
@donsizemore Would you update from develop? This is still using the 4.14 version. Thanks! |
@kcondon done. thank you! |
@donsizemore I'm still seeing v4.14. Is that what you're seeing? |
…_bagit_export2_local_fs
@kcondon sorry, i need more coffee. how about now? |
@donsizemore Just had some coffee myself. That did it, thanks! |
Tested, works. Ready for merge. |
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist