Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5253 metrics block ui #6040

Merged
merged 35 commits into from
Aug 9, 2019
Merged

5253 metrics block ui #6040

merged 35 commits into from
Aug 9, 2019

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jul 19, 2019 •
edited
Loading

Closes #5253

Related to #1969

mheppler and others added 17 commits June 25, 2019 13:01
@mheppler
Initial dataset pg layout revisions to move metrics block [ref #5253]
e73cb0e
@mheppler
Refactoring dataset and file pg grid layout to get it more uniform ac…
b2f037f 
…ross the two pgs [ref #5253]
@mheppler
Moved metrics block on file and dataset pgs, moved some stuff around …
3a566a1 
…to make room, added placeholder static content for dynamic MDC metrics [ref #5253]
@mheppler
Merge branch 'develop' into 5253-metrics-block-ui
7113c2e
@pdurbin
Merge branch 'develop' into 5253-metrics-block-ui #5253
b901cc3
@pdurbin
add TOC and easier way to start dev on UI #5253
3760d31
@pdurbin
wire up downloads and views on dataset page #5253
bc5d512
@pdurbin
add render logic for classic vs MDC metrics #5253
4483342
@pdurbin
better example, a citation from a paper #5253
4d87282
@pdurbin
add table of config options #5253
ac5de7f
@pdurbin
help devs insert MDC citation #5253
a2a7b4b
@mheppler
Cleaned up UI of prototype code for metrics block, move placeholder l…
bf79aa1 
…abel desc to bundle, added render logic to file pg [ref #5253]
@mheppler
Additional UI clean up of dataset and file pg citation blocks and met…
65d533d 
…rics blocks [ref #5253]
@mheppler
Added static Dataset Citations popup linked from Dataset Metrics bloc…
4ea8bcd 
…k [ref #5253]
@pdurbin
fix typo to get citations #5253
4b7370b
@pdurbin
connect citation URLs from db to wireframe #5253
29ec5b7
@pdurbin
more elaborate tooltips #5253
0cc3a78
@coveralls
Copy link

coveralls commented Jul 19, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 19.493% when pulling a621e7b on 5253-metrics-block-ui into aa4d314 on develop.

@pdurbin pdurbin marked this pull request as ready for review July 19, 2019 15:12
@pdurbin pdurbin mentioned this pull request Jul 19, 2019
Closed
sekmiller
sekmiller requested changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 411: "DATASET CITATIONS LINK TITLE HERE"
needs to be bundle-ized with a real title?

@mheppler
Copy link
Contributor

Line 411: "DATASET CITATIONS LINK TITLE HERE"
needs to be bundle-ized with a real title?

Fixed. Removed the title attribute from the link.

@pdurbin pdurbin removed their assignment Jul 22, 2019
@pdurbin
Copy link
Member Author

pdurbin commented Jul 22, 2019

@sekmiller I got settingsWrapper working in 0b4d21f if you'd like to take a look.

@djbrooke djbrooke removed their assignment Jul 22, 2019
@djbrooke djbrooke requested a review from sekmiller July 23, 2019 15:15
@djbrooke djbrooke self-assigned this Jul 23, 2019
sekmiller
sekmiller approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also helped Phil with the rendering

@djbrooke djbrooke removed their assignment Jul 23, 2019
@pdurbin pdurbin mentioned this pull request Jul 26, 2019
Closed
@kcondon kcondon self-assigned this Jul 31, 2019
@kcondon kcondon merged commit 95e0443 into develop Aug 9, 2019
@kcondon kcondon deleted the 5253-metrics-block-ui branch August 9, 2019 17:17
@djbrooke djbrooke added this to the 4.16 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheppler mheppler mheppler left review comments

@sekmiller sekmiller sekmiller approved these changes

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.16
Development

Successfully merging this pull request may close these issues.

Display Make Data Count use and citation metrics
7 participants
@pdurbin @coveralls @mheppler @sekmiller @kcondon @djbrooke @TaniaSchlatter