Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6877 navbar guide url #6879

Merged
merged 3 commits into from
May 4, 2020
Merged

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Apr 30, 2020

What this PR does / why we need it:
Please see the discussion in #6877 for details (I don't like to repeat that here... 😉 )

Which issue(s) this PR closes:

Closes #6877
Relates to #3637

Special notes for your reviewer:
None.

Suggestions on how to test this:
Deploy. Set the new setting. Check if the "User Guide" link in the navigation bar is pointing to the new location.

Does this PR introduce a user interface change?:
Yes, but @TaniaSchlatter said it's fine.

Is there a release notes update needed for this change?:
Maybe? It really is a very simple and small change.

Additional documentation:
None.

@poikilotherm poikilotherm added UX & UI: Design This issue needs input on the design of the UI and from the product owner Feature: Installation Guide labels Apr 30, 2020
@poikilotherm poikilotherm added this to the Dataverse 5 milestone Apr 30, 2020
@coveralls
Copy link

coveralls commented Apr 30, 2020

Coverage Status

Coverage remained the same at 19.63% when pulling 5cec042 on poikilotherm:6877-navbar-guide-url into 5ffc7b0 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The issue has a lot of discussion about this feature.

@mheppler
Copy link
Contributor

mheppler commented Apr 30, 2020

@poikilotherm the whole point of that initial question, "What this PR does / why we need it:" in the PR template is so that the developer can provide everyone a brief description of what these changes provide, without requiring them to read an entire conversation in an issue with dozens of comments. 👍

@poikilotherm
Copy link
Contributor Author

@poikilotherm the whole point of that initial question, "What this PR does / why we need it:" in the PR template is so that the developer can provide everyone a brief description of what these changes provide, without requiring them to read an entire conversation in an issue with dozens of comments. +1

You are absolutely right. Normally I add sophisticated writeups in that section. This time, for this very small change and @pdurbin already done with the review before the PR even existed, I didn't want to re-emphasize... Promise I'll do this for other PRs.

@kcondon kcondon self-assigned this May 4, 2020
@kcondon kcondon merged commit f8a460e into IQSS:develop May 4, 2020
@poikilotherm poikilotherm deleted the 6877-navbar-guide-url branch August 10, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Installation Guide UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting for navbar guide URL override
5 participants