-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6877 navbar guide url #6879
6877 navbar guide url #6879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The issue has a lot of discussion about this feature.
@poikilotherm the whole point of that initial question, "What this PR does / why we need it:" in the PR template is so that the developer can provide everyone a brief description of what these changes provide, without requiring them to read an entire conversation in an issue with dozens of comments. 👍 |
You are absolutely right. Normally I add sophisticated writeups in that section. This time, for this very small change and @pdurbin already done with the review before the PR even existed, I didn't want to re-emphasize... Promise I'll do this for other PRs. |
What this PR does / why we need it:
Please see the discussion in #6877 for details (I don't like to repeat that here... 😉 )
Which issue(s) this PR closes:
Closes #6877
Relates to #3637
Special notes for your reviewer:
None.
Suggestions on how to test this:
Deploy. Set the new setting. Check if the "User Guide" link in the navigation bar is pointing to the new location.
Does this PR introduce a user interface change?:
Yes, but @TaniaSchlatter said it's fine.
Is there a release notes update needed for this change?:
Maybe? It really is a very simple and small change.
Additional documentation:
None.