Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6980 datacite reservation upgrade #7142

Merged
merged 16 commits into from
Aug 5, 2020
Merged

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:

This is a documentation-only PR, the upgrade instructions for installations using Datacite - the DOIs for any unpublished drafts will need to be reserved.
See the discussion in the issue #6980 for more information.

Which issue(s) this PR closes:

Closes #6980

Special notes for your reviewer:

The good news is that we don't need to do anything special for any DOIs that are "unpublished" in the Dataverse, but somehow already exist on the Datacite side. It's not even necessary to check if any such cases exist before running the batch reserve job as described in the instruction.

Suggestions on how to test this:

Can be tested on any system running the develop branch (in its current state), and configured with a Datacite test account (not "fake"!). If it has any datasets created before the "reserve DOIs" PR was merged, they will be reported by the "unreserved" API, and they can be reserved as described in the instruction. If there are no such legacy unreserved DOIs, the condition can be emulated by setting the GlobalIdCreateTime to null in the dvobject table for some draft dataset(s).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@landreev landreev added this to the Dataverse 5 milestone Jul 29, 2020
@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage decreased (-0.07%) to 19.546% when pulling 97b92e4 on 6980-datacite-reservation-upgrade into 352b17f on develop.

@@ -0,0 +1,28 @@
# Dataverse installatins using Datacite: upgrade action required.

For Dataverses using Datacite v5.0 changes the process of registering the Global Identifier (DOI) for the dataset. Instead of registering it when the dataset is published for the first time, Dataverse will try to "reserve" the DOI when it's created (by registering it as a "draft", using Datacite terminology). When the user publishes the dataset, the DOI will be publicized as well (by switching the registration status to "findable").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For Dataverses using Datacite v5.0 changes the process of registering the Global Identifier (DOI) for the dataset. Instead of registering it when the dataset is published for the first time, Dataverse will try to "reserve" the DOI when it's created (by registering it as a "draft", using Datacite terminology). When the user publishes the dataset, the DOI will be publicized as well (by switching the registration status to "findable").
For installations using Dataverse v5.x, the process of registering the Global Identifier (DOI) for the dataset changes. Instead of registering it when the dataset is published for the first time, Dataverse will try to "reserve" the DOI when it's created (by registering it as a "draft", using Datacite terminology). When the user publishes the dataset, the DOI will be publicized as well (by switching the registration status to "findable").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is this really true for all types of PIDs? I couldn't tell from a quick view at the code, but if not, maybe this should be more Datacite-using specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I can change "dataverses" to "installations" if you prefer; but otherwise your proposed commit is changing what I am actually trying to say, somewhat. We want it to say "dataverses (or installations) using Datacite" - because this is Datacite-specific, and I do want to repeat it in this paragraph. That sentence may need a comma - but I don't think it should go where you are adding it. I meant to say something along the lines of
"For (Dataverse) installations (that are) using Datacite, (the upgrade to) v5.0 will change the process of ..."

May not have been my best sentence ever, I'll try improve it. But not sure I like your version either, sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. I was just concerned by a non-existing "DataCite 5.0" 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A missing period? using Datacite. v5.x changes....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qqmyers it should be properly punctuated in the current version, yes.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks fine. Is github not showing the formatted output because this doesn't have a .rst extension? (Or is there a format problem? Could release notes get a .rst extension to make them more readable in github?)

@poikilotherm
Copy link
Contributor

poikilotherm commented Jul 29, 2020

Maybe better use Markdown as release notes on GitHub are using Markdown instead of Restructured Text. Sphinx offers support for rendering Markdown files aside rST, using this in dv-k8s...

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. Added a suggestion. Otherwise looks good. I love that the script is only some slight editing away from being a one-liner.

doc/release-notes/6980-datacite-reservation-upgrade Outdated Show resolved Hide resolved
doc/release-notes/6980-datacite-reservation-upgrade Outdated Show resolved Hide resolved
landreev and others added 2 commits July 29, 2020 14:56
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@landreev
Copy link
Contributor Author

Yes, I always get conufsed, about markdown vs. rst... But what is it that it currently doesn't like - the "tripple back tick"? I thought that was md... Will check!

@qqmyers
Copy link
Member

qqmyers commented Jul 29, 2020

Could just be the lack of a file extension? There's a mix of .md and no extension in the doc/release-notes dir and the .md ones are rendering

@landreev
Copy link
Contributor Author

Could just be the lack of a file extension? There's a mix of .md and no extension in the doc/release-notes dir and the .md ones are rendering

D'oh!
(thank you @qqmyers)

@landreev
Copy link
Contributor Author

(let's put this PR on hold, until #7147 is finalized)

@landreev landreev self-assigned this Aug 4, 2020
@landreev landreev removed their assignment Aug 4, 2020
@pdurbin pdurbin self-assigned this Aug 4, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I made a few suggestions, changing a word here or there, removing a sentence.

To nitpick, it should be "DataCite." I hate it when people call us "DataVerse."

doc/release-notes/6980-datacite-reservation-upgrade.md Outdated Show resolved Hide resolved
doc/release-notes/6980-datacite-reservation-upgrade.md Outdated Show resolved Hide resolved
doc/release-notes/6980-datacite-reservation-upgrade.md Outdated Show resolved Hide resolved
@pdurbin pdurbin assigned landreev and unassigned pdurbin Aug 4, 2020
@landreev landreev removed their assignment Aug 4, 2020
@kcondon kcondon self-assigned this Aug 5, 2020
@kcondon kcondon merged commit 7e6f5eb into develop Aug 5, 2020
@kcondon kcondon deleted the 6980-datacite-reservation-upgrade branch August 5, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reserving Datacite DOIs asynchronously
6 participants