Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guava library which is reported as potential security issue. D… #7163

Closed
wants to merge 1 commit into from

Conversation

rtreacy
Copy link
Contributor

@rtreacy rtreacy commented Aug 5, 2020

…ependency is apparently very old and not necessary any longer. Code compiles cleanly when the dependency is removed from the project

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

…ependency is apparently very old and not necessary any longer. Code compiles cleanly when the dependency is removed from the project
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.546% when pulling 5eb0dc1 on rtreacy:security17-guava-remove into 8223e27 on IQSS:develop.

@rtreacy
Copy link
Contributor Author

rtreacy commented Aug 5, 2020

Need to take another look at this. Removing the dependency from the pom causes a later version of the library to be pulled in, but it still has the reported memory problem.

@rtreacy
Copy link
Contributor Author

rtreacy commented Aug 6, 2020

One source of the dependency is the use of org.everit.json.schema.* in edu.harvard.iq.dataverse.provenance.ProvInvestigator
It was introduce in 2018. Can this json functionality be implemented with standARD Java EE json?

@qqmyers
Copy link
Member

qqmyers commented Aug 6, 2020

FWIW: I think the google cloud library I've used in #7140 uses guava and if I recall correctly, it needs a newer version ((v>20) than the one in Glassfish (in the /modules subdir). I'm not sure if payara also uses guava as glassfish did, but that's something to check.

@pdurbin
Copy link
Member

pdurbin commented Aug 6, 2020

One source of the dependency is the use of org.everit.json.schema.* in edu.harvard.iq.dataverse.provenance.ProvInvestigator
It was introduce in 2018. Can this json functionality be implemented with standARD Java EE json?

The functionality is validating JSON files against a JSON Schema. I don't know if Java/Jakarta EE does that or not. Good question.

A quick search isn't promising:

@rtreacy rtreacy closed this Aug 19, 2020
@poikilotherm
Copy link
Contributor

FWIW @pdurbin JSON Schema is about to become an IETF standard some day. See https://json-schema.org/

@rtreacy
Copy link
Contributor Author

rtreacy commented Aug 26, 2020

btw, it turned out that there were 5 libraries we use that are dependent on guava. Instead of removing it, there is now a pull request that upgrades the guava version to 29.0-jre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants