Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6810 - refactor JSON deps #7261

Closed

Conversation

poikilotherm
Copy link
Contributor

What this PR does / why we need it:
Remove the JSON library usage mess and streamline into using Jakarta EE 8 APIs.
Add support for JSON Schema validation using the same APIs, replacing old and outdated everit library.

Which issue(s) this PR closes:

Closes #6810

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:
The https://github.com/everit-org/json-schema library has been updated, but not releasing packages to Maven Central. Instead of adding just another repo, replace the library and remove a dep on Guava + Gson.

@poikilotherm poikilotherm added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Sep 11, 2020
@poikilotherm poikilotherm added this to the 5.1 milestone Sep 11, 2020
@poikilotherm poikilotherm self-assigned this Sep 11, 2020
@coveralls
Copy link

coveralls commented Sep 11, 2020

Coverage Status

Coverage decreased (-0.002%) to 19.478% when pulling aa6b66e on poikilotherm:6810-refactor-json-deps into c7d63c1 on IQSS:develop.

Back in the days of IQSS#2290 (2016), code for JSON serialization has been introduced. This has never been used, all DataFile objects are still serialized as JSON by util.JsonPrinter. Removing this 4 year old, completely unused code.

If used in the future again, this should be done based on Jakarta JSON-B.
@djbrooke djbrooke removed this from the 5.1 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Gson, Jackson and Everit JSON Schema Validation code dependencies
4 participants