-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iqss/7140 google cloud archiver #7292
Merged
kcondon
merged 20 commits into
IQSS:develop
from
QualitativeDataRepository:IQSS/7140-GoogleCloudArchiver
Oct 9, 2020
Merged
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
bf6ca00
add google archiver and dependencies
qqmyers ee08e9c
documentation
qqmyers 5dfbae3
update DuraCloud archiver with enhancements from Google archiver
qqmyers fed5e45
typos
qqmyers 4d1b4b0
capitalization
qqmyers 3eb0ebc
for example
qqmyers 3e5eecf
adding settings to master list
qqmyers ede2a22
add formatting
qqmyers a33b9b1
simplify links
qqmyers 4aeccfd
add release notes
djbrooke 558f008
Merge branch 'IQSS/7140-GoogleCloudArchiver' of https://github.com/Qu…
djbrooke c257a1e
Update doc/sphinx-guides/source/installation/config.rst
djbrooke 57e6b42
Update doc/sphinx-guides/source/installation/config.rst
djbrooke babb316
typo fixes
qqmyers f2b1b44
Merge branch 'IQSS/7140-GoogleCloudArchiver' of https://github.com/Qu…
qqmyers 71dd1b9
Merge remote-tracking branch 'IQSS/develop' into IQSS/7140-GoogleClou…
qqmyers ed90534
Merge remote-tracking branch 'IQSS/develop' into IQSS/7140-GoogleClou…
qqmyers ab29f15
typo
qqmyers af6dc98
expanded directions
qqmyers 3484bb6
typos
qqmyers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When all the BagIt export stuff was initially merged, it didn't dawn on me that we lost our comprehensive list of settings in one place.
I think it would be nice to document :ArchiverSettings in the big list and probably all the various sub-settings like :GoogleCloudBucket, :GoogleCloudProject, and the older ones (:BagItLocalPath, etc.).
From a code perspective, I think I'd also like to see strings like :GoogleCloudBucket, :GoogleCloudProject, :BagItLocalPath, etc. added to the "Key" enum in SettingsServiceBean.java. That way, developers can also have a comprehensive list of all settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add them to the guides list. The :ArchiverSettings is a Key already. For the others, I think earlier discussions questioned whether the archive-specific classes would end up being deployed separately, in which case having their settings in the core would be odd. Since that's not on the roadmap at this point, I could move them temporarily if you think its worth the effort.