3438 email verification 0121 #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify btn on account pg [ref #3438]
|
@sekmiller I sent you a suggestion for how to do this without the remote command via slack. |
scolapasta
approved these changes
Jan 21, 2021
scolapasta
approved these changes
Jan 21, 2021
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug where the page refresh of dataverse user resends the email verification. Also keeps the "Verify Email" button available while the user's email is unverified.
Which issue(s) this PR closes:
Closes #3438
Special notes for your reviewer: The underlying cause of the bug was that the page load/refresh was triggering the sendConfirmEmail method which was in the action of the verify button. To fix it I moved it to a remote command. If there's a better way to handle it, I'm open to suggestions.
Also note that the branch has a -0121 on the end of its name due to some git issue I had last week.
Suggestions on how to test this:
I noticed one thing in my testing that I wasn't able to recreate: at least once there was a time when the user had an active token but pressing the "verify" button did not cause the popup to display. I also had an issue where refreshing the page would resend the confirmation email. I think that is resolved.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
UI changes have been reviewed/approved by the design team. #3438 (comment)
Is there a release notes update needed for this change?:
no
Additional documentation:
none