Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8169- advanced search page accessibility #8170

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 20, 2021

What this PR does / why we need it: Addresses accessibility issues in the advanced search page by associating labels with input fields.

Which issue(s) this PR closes:

Closes #8169

Special notes for your reviewer:

Suggestions on how to test this: One way is to install https://www.deque.com/axe/ and run it on the advanced search page.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: only changes the accessibility aspects/no visible changes

Is there a release notes update needed for this change?: no

Additional documentation:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the changes seem non-controversial and straightforward (more labels and ids on the xhtml side).

@kcondon kcondon merged commit 2f4a6ad into IQSS:develop Oct 21, 2021
@djbrooke djbrooke added this to the 5.8 milestone Oct 21, 2021
@qqmyers qqmyers deleted the IQSS/8169-accessibility_advanced_search branch May 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: advanced search form
4 participants