Validation fix and API call #8788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added the JSONUtil methods I've mentioned that make it easy to get JsonObject/JsonArray from a string. The prettyprint methods are already there to go the other way. |
rtreacy
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits fix a misconception in the validation routine and then add an api call to test with. I haven't done more than compile this so there could still be bugs. The api call should allow requests POSTing a json object with
"url" - the unsigned url you want (must be exact with any dataset/file id, etc.
"method" - optional - GET is assumed
"timeout" - optional - 10 minutes is assumed
"userId" - optional - the user id string - assumes the superuser using this API.