9224 - revert workflow metadata block in Solr schema #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poikilotherm
added
HERMES
pdurbin
reviewed
Dec 13, 2022
|
Looks great. I made a tiny suggestion. Otherwise this is ready for QA. Gave it a 3 (the smallest possible) as a size. |
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
|
@poikilotherm right, merging is blocked until someone clicks "approve" in a review. But first things first. This PR hasn't been prioritized yet. It's currently at the bottom of the HERMES column at https://github.com/orgs/IQSS/projects/34/views/1 . The goal is the "1️⃣ ▶ORDERED BACKLOG (Stefano)" column and eventually into a sprint at https://github.com/orgs/IQSS/projects/2 . I hope that makes sense. I think we should document this as part of this issue: |
|
backlog grooming
|
scolapasta
approved these changes
Feb 6, 2023
pdurbin
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed for #7877, we don't want experimental metadata block fields in the out-of-the-box
schema.xml, but introduced them for the workflow schema in #8812.Which issue(s) this PR closes:
Closes #9224
Special notes for your reviewer:
Please review the docs changes to give people a heads up.
See https://dataverse-guide--9225.org.readthedocs.build/en/9225/user/appendix.html#experimental-metadata for preview.
Suggestions on how to test this:
Delete the fields, reindex, you're done.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
🔋 included
Additional documentation:
🔋 included