3818 Delete temporary thumbnail files #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added
Feature: File Upload & Handling
Size: 3
|
@haarli, we'd like to merge this PR. Can you please update this branch with the latest from develop and see if the Jenkins build succeeds? Thanks! |
|
@sekmiller Sure, the branch is now updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With S3 storage activated, Dataverse creates temporary thumbnail files (tempFileForRescale*.tmp) for image and PDF ingests. After the thumbnails are uploaded to S3, the temporary files are not deleted. Our tmp directory currently grew up to over 180GB .
This PR deletes the tempFileForRescale*.tmp files silently after they are uploaded to S3.
Which issue(s) this PR closes: