Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "query" tool type, "Ask the Data" #9737

Merged
merged 48 commits into from
Aug 3, 2023
Merged

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Jul 26, 2023

What this PR does / why we need it:
Adds a new type of external tool, the query type in support of the new "Ask Dataverse" tool. Includes a tool manifest for installing "Ask the Data" and a new icon to display on the file list for all data tables that are the correct content type (.tab)

Which issue(s) this PR closes:

Closes #9663 Add "Ask Dataverse" tool to Dataverse

Special notes for your reviewer: On the tools tab Preview and Query are combined on what was formerly just the preview tab.

Suggestions on how to test this: The tool manifest for AskTheData is in Stefano's repo https://github.com/IQSS/askdataverse/tree/main/askthedata If it's not working you may have to check with Stefano to make sure he has it running. Also the current icon is a placeholder waiting for Dwayne to make a custom one for release.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation: docs have been updated including the available tool list

@sekmiller sekmiller added this to the 5.14 milestone Jul 26, 2023
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@pdurbin pdurbin self-assigned this Jul 26, 2023
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready for QA.

@pdurbin pdurbin changed the title 9663 add ask dataverse add "query" tool type and list "Ask the Data" tool Jul 31, 2023
@pdurbin pdurbin removed their assignment Jul 31, 2023
@github-actions

This comment has been minimized.

@pdurbin pdurbin changed the title add "query" tool type and list "Ask the Data" tool add "query" tool type, "Ask the Data" Jul 31, 2023
@kcondon kcondon self-assigned this Jul 31, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9663-add-AskDataverse
ghcr.io/gdcc/configbaker:9663-add-AskDataverse

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@kcondon kcondon merged commit 05743fd into develop Aug 3, 2023
12 checks passed
@kcondon kcondon deleted the 9663-add-AskDataverse branch August 3, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Ask Dataverse" tool to Dataverse
5 participants