-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "query" tool type, "Ask the Data" #9737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for QA.
pdurbin
changed the title
9663 add ask dataverse
add "query" tool type and list "Ask the Data" tool
Jul 31, 2023
This comment has been minimized.
This comment has been minimized.
pdurbin
changed the title
add "query" tool type and list "Ask the Data" tool
add "query" tool type, "Ask the Data"
Jul 31, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new type of external tool, the query type in support of the new "Ask Dataverse" tool. Includes a tool manifest for installing "Ask the Data" and a new icon to display on the file list for all data tables that are the correct content type (.tab)
Which issue(s) this PR closes:
Closes #9663 Add "Ask Dataverse" tool to Dataverse
Special notes for your reviewer: On the tools tab Preview and Query are combined on what was formerly just the preview tab.
Suggestions on how to test this: The tool manifest for AskTheData is in Stefano's repo https://github.com/IQSS/askdataverse/tree/main/askthedata If it's not working you may have to check with Stefano to make sure he has it running. Also the current icon is a placeholder waiting for Dwayne to make a custom one for release.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: docs have been updated including the available tool list