fix(linter): keep rules disabled if the rule is not enabled in the co…

…nfig (oxc-project#2031)

relates oxc-project#1969

crates/oxc_cli/fixtures/no_console_off/eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "no-console": "off"
+  }
+}

crates/oxc_cli/fixtures/no_console_off/test.js

@@ -0,0 +1 @@
+console.log()

crates/oxc_cli/src/lint/mod.rs

@@ -363,6 +363,16 @@ mod test {
         assert_eq!(result.number_of_errors, 0);
     }
 
+    #[test]
+    fn no_console_off() {
+        let args =
+            &["-c", "fixtures/no_console_off/eslintrc.json", "fixtures/no_console_off/test.js"];
+        let result = test(args);
+        assert_eq!(result.number_of_files, 1);
+        assert_eq!(result.number_of_warnings, 0);
+        assert_eq!(result.number_of_errors, 0);
+    }
+
     #[test]
     fn typescript_eslint() {
         let args = &[

crates/oxc_linter/src/config/mod.rs

@@ -88,20 +88,23 @@ impl ESLintConfig {
                     let rule_config = &rule_configs[0];
                     let rule_name = &rule_config.rule_name;
                     let plugin_name = &rule_config.plugin_name;
-                    if let Some(rule) = rules_for_override.iter().find(|r| r.name() == rule_name) {
-                        match rule_config.severity {
-                            AllowWarnDeny::Warn | AllowWarnDeny::Deny => {
+                    match rule_config.severity {
+                        AllowWarnDeny::Warn | AllowWarnDeny::Deny => {
+                            if let Some(rule) = all_rules
+                                .iter()
+                                .find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
+                            {
                                 rules_to_replace.push(rule.read_json(rule_config.config.clone()));
                             }
-                            AllowWarnDeny::Allow => {
+                        }
+                        AllowWarnDeny::Allow => {
+                            if let Some(rule) = rules_for_override
+                                .iter()
+                                .find(|r| r.name() == rule_name && r.plugin_name() == plugin_name)
+                            {
                                 rules_to_remove.push(rule.clone());
                             }
                         }
-                    } else if let Some(rule) = all_rules
-                        .iter()
-                        .find(|r| r.plugin_name() == plugin_name && r.name() == rule_name)
-                    {
-                        rules_to_replace.push(rule.read_json(rule_config.config.clone()));
                     }
                 }
                 _ => {