icingaweb2: Adjust preferences settings to store preferences in database #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, will document that the value is changed for previous versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the changelog of Icinga Web 2 a user was not allowed to set the preferences to be stored in ini format since 2.9 and forced to do the migration in 2.11.
This means this change will make preferences work for current installation of 2.11 and newer and only break versions prior to 2.9, anyone who had this setting in 2.9 or 2.10 has to run the migration described in the changelog and it is very likely it was run already to be compatible.
So I did try to avoid complexity by considering this as bug fix and not a breaking change and trying to avoid it.