Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add molecule tests to collection #42

Merged
merged 25 commits into from
Jul 4, 2021
Merged

Add molecule tests to collection #42

merged 25 commits into from
Jul 4, 2021

Conversation

widhalmt
Copy link
Member

Fixes #41

@widhalmt widhalmt requested review from lbetz and mkayontour May 25, 2021 10:48
@widhalmt widhalmt self-assigned this May 25, 2021
@widhalmt widhalmt marked this pull request as draft May 25, 2021 10:48
@widhalmt
Copy link
Member Author

Some of the checks won't run locally as easy as they do in GitHub actions. So this might get a long trail of trial&error commits before it's ready to merge.

@widhalmt widhalmt marked this pull request as ready for review May 25, 2021 14:14
@widhalmt
Copy link
Member Author

@lbetz / @mkayontour please tell me what you think of the code.

Please don't just merge it now. We'll need to make very sure to have the commits squashed during merging and I want to review all the commit messages. There's a lot in them that was just used "under way" but doesn't bring any benefit when we have it in the history of main.

README.md Outdated
@@ -1,5 +1,7 @@
# ansible-collection-icinga

[![CI](https://github.com/Icinga/ansible-collection-icinga/workflows/CI/badge.svg?event=push)](https://github.com/Icinga/ansible-collection-icinga/actions?query=workflow%3ACI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other badge should work, once it's merged. The pipelines the link is referring to, does not yet exist. But we can always change it to the more generic one to be safe. I'll change it.

Copy link
Member

@mkayontour mkayontour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, for the basics this is enough. I'll add a few more cases and scenarios after the merge is done!

The install.rst is something I would remove - because it could be distracting but let me hear what you think.
Thanks buddy :)

molecule/default/INSTALL.rst Outdated Show resolved Hide resolved
@widhalmt
Copy link
Member Author

widhalmt commented Jun 8, 2021

Thanks for your feedback, @mkayontour . I tried to apply the changes you requested. Could you have another look?

@widhalmt widhalmt requested a review from mkayontour June 8, 2021 09:33
@widhalmt
Copy link
Member Author

widhalmt commented Jul 4, 2021

Talked to @lbetz . He's swamped with other tasks now but he's ok, with me merging. So: merging. Yay.

@widhalmt widhalmt merged commit 4523a79 into main Jul 4, 2021
@widhalmt widhalmt deleted the feature-molecule-41 branch July 4, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic tests
2 participants