-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add molecule tests to collection #42
Conversation
Some of the checks won't run locally as easy as they do in GitHub actions. So this might get a long trail of trial&error commits before it's ready to merge. |
@lbetz / @mkayontour please tell me what you think of the code. Please don't just merge it now. We'll need to make very sure to have the commits squashed during merging and I want to review all the commit messages. There's a lot in them that was just used "under way" but doesn't bring any benefit when we have it in the history of main. |
README.md
Outdated
@@ -1,5 +1,7 @@ | |||
# ansible-collection-icinga | |||
|
|||
[![CI](https://github.com/Icinga/ansible-collection-icinga/workflows/CI/badge.svg?event=push)](https://github.com/Icinga/ansible-collection-icinga/actions?query=workflow%3ACI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI Status doesn't work, this generic one does work.
https://github.com/Icinga/ansible-collection-icinga/actions/workflows/molecule.yml/badge.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other badge should work, once it's merged. The pipelines the link is referring to, does not yet exist. But we can always change it to the more generic one to be safe. I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, for the basics this is enough. I'll add a few more cases and scenarios after the merge is done!
The install.rst is something I would remove - because it could be distracting but let me hear what you think.
Thanks buddy :)
Thanks for your feedback, @mkayontour . I tried to apply the changes you requested. Could you have another look? |
Talked to @lbetz . He's swamped with other tasks now but he's ok, with me merging. So: merging. Yay. |
Fixes #41