Limit contact.username to 254 chars

Icinga · Jul 3, 2024 · 35ecfa7 · 35ecfa7
1 parent 8791c69
commit 35ecfa7
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/library/Notifications/Web/Form/ContactForm.php b/library/Notifications/Web/Form/ContactForm.php
@@ -16,6 +16,7 @@
 use ipl\Stdlib\Filter;
 use ipl\Validator\CallbackValidator;
 use ipl\Validator\EmailAddressValidator;
+use ipl\Validator\StringLengthValidator;
 use ipl\Web\Common\CsrfCounterMeasure;
 use ipl\Web\Compat\CompatForm;
 
@@ -95,20 +96,23 @@ protected function assemble()
             'username',
             [
                 'label' => $this->translate('Username'),
-                'validators' => [new CallbackValidator(function ($value, $validator) {
-                    $contact = Contact::on($this->db)->filter(Filter::equal('username', $value));
-                    if ($this->contactId) {
-                        $contact->filter(Filter::unequal('id', $this->contactId));
-                    }
-
-                    if ($contact->first() !== null) {
-                        $validator->addMessage($this->translate('A contact with the same username already exists.'));
-
-                        return false;
-                    }
-
-                    return true;
-                })]
+                'validators' => [
+                    new StringLengthValidator(['max' => 254]),
+                    new CallbackValidator(function ($value, $validator) {
+                        $contact = Contact::on($this->db)->filter(Filter::equal('username', $value));
+                        if ($this->contactId) {
+                            $contact->filter(Filter::unequal('id', $this->contactId));
+                        }
+
+                        if ($contact->first() !== null) {
+                            $validator->addMessage($this->translate('A contact with the same username already exists.'));
+
+                            return false;
+                        }
+
+                        return true;
+                    })
+                ]
             ]
         )->addElement(
             'select',