Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel default value by changing default logic #206

Merged
merged 1 commit into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. Channel default value by changing default logic

    In a nutshell, the newly introduced plugin.PopulateDefaults function
    populates all fields of a Plugin-implementing struct with those fields
    from Info.ConfigAttributes where ConfigOption.Default is set. Thus, a
    single function call before parsing the user-submitted configuration
    within the Plugin.SetConfig method sets default values.
    
    As a result of the discussion between the Go and the Web team,
    summarized in #205, Web does not store key-value pairs to be omitted.
    
    Prior, an already JSON-encoded version of the ConfigOption slice was
    present in plugin.Info. Thus, this data wasn't easily available anymore.
    As the new code now needs to access this field, it was changed and a
    custom sql driver.Valuer was implemented for a slice type.
    
    While working on this, all ConfigOptions were put in the same order as
    the struct fields.
    
    Requires <Icinga/icinga-notifications-web#230>.
    
    Closes #205.
    oxzi committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    53448cb View commit details
    Browse the repository at this point in the history