-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor browser_session
table
#215
Conversation
60c7fc2
to
3258b8e
Compare
Is that really due to that? Is there any remaining doubt that the username can be treated case-insensitive? To my current knowledge, there seems to be some inconsistency in Icinga Web there between MySQL/MariaDB and PostgreSQL, but neither allows you to have users whose names differ only in case. |
That's correct. We don't support different usernames solely based on their case sensitivity. |
#71 was merged earlier today so now there's a precedent for using |
3258b8e
to
9cc76ca
Compare
@julianbrost I rebased this PR and reverted the username changes. |
The PHP daemon now supplies the unix timestamp: Icinga/icinga-notifications-web@d1db5d4
9cc76ca
to
61bfb90
Compare
Targets #135 Depends on Icinga/icinga-notifications#136 Depends on Icinga/icinga-notifications#215
This PR modifies the
browser_session
table to reflect new changes to the data structure.username
oruser_agent
, as the session storage hook takes care of zombie entries before inserting new session data.authenticated_at
index.username
anduser_agent
conditions.authenticated_at
got removed, as the timestamp now gets supplied by the PHP daemon itself.Fixes Icinga/icinga-notifications-web#194
Fixes Icinga/icinga-notifications-web#195