ApiListener: Process cluster config updates sequentially

Icinga · Feb 13, 2024 · 087c8b5 · 087c8b5
1 parent 215daeb
commit 087c8b5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/remote/apilistener-configsync.cpp b/lib/remote/apilistener-configsync.cpp
@@ -7,6 +7,7 @@
 #include "base/configtype.hpp"
 #include "base/json.hpp"
 #include "base/convert.hpp"
+#include "base/defer.hpp"
 #include "config/vmops.hpp"
 #include <fstream>
 
@@ -104,6 +105,13 @@ Value ApiListener::ConfigUpdateObjectAPIHandler(const MessageOrigin::Ptr& origin
 		return Empty;
 	}
 
+	// Wait for the object name to become available for processing and block it immediately.
+	listener->m_ObjectConfigChangeLock.WaitForObject(ptype, objName);
+
+	Defer unlockAndNotifyOne([&listener, &ptype, &objName]{
+		listener->m_ObjectConfigChangeLock.UnBlockNotify(ptype, objName);
+	});
+
 	ConfigObject::Ptr object = ctype->GetObject(objName);
 
 	String config = params->Get("config");
@@ -258,6 +266,13 @@ Value ApiListener::ConfigDeleteObjectAPIHandler(const MessageOrigin::Ptr& origin
 		return Empty;
 	}
 
+	// Wait for the object name to become available for processing and block it immediately.
+	listener->m_ObjectConfigChangeLock.WaitForObject(ptype, objName);
+
+	Defer unblockAndNotifyOne([&listener, &ptype, &objName]{
+		listener->m_ObjectConfigChangeLock.UnBlockNotify(ptype, objName);
+	});
+
 	ConfigObject::Ptr object = ctype->GetObject(objName);
 
 	if (!object) {

diff --git a/lib/remote/apilistener.hpp b/lib/remote/apilistener.hpp
@@ -271,6 +271,9 @@ class ApiListener final : public ObjectImpl<ApiListener>
 	mutable std::mutex m_ActivePackageStagesLock;
 	std::map<String, String> m_ActivePackageStages;
 
+	/* ensures that at most one create/update/delete is being processed per object at each time */
+	mutable ObjectNameMutex m_ObjectConfigChangeLock;
+
 	void UpdateActivePackageStagesCache();
 };