Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jobs command options #184

Closed
wants to merge 0 commits into from
Closed

Add jobs command options #184

wants to merge 0 commits into from

Conversation

yhabteab
Copy link
Member

fixes #181

@yhabteab yhabteab added the enhancement New feature or improvement label Jun 12, 2023
@yhabteab yhabteab added this to the 1.2.2 milestone Jun 12, 2023
@yhabteab yhabteab self-assigned this Jun 12, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 12, 2023
@yhabteab yhabteab force-pushed the add-scan-options-to-jobs-command branch from 7091caa to 9266b0a Compare June 14, 2023 14:23
@yhabteab yhabteab requested a review from lippserd June 14, 2023 14:24
lippserd
lippserd requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please remove the command line options and instead add these options as job settings that can be configured via Web (INI).

@yhabteab yhabteab force-pushed the add-scan-options-to-jobs-command branch from 9266b0a to e61be5a Compare July 19, 2023 07:30
@yhabteab yhabteab closed this Jul 19, 2023
@yhabteab yhabteab force-pushed the add-scan-options-to-jobs-command branch from e61be5a to 32e37b3 Compare July 19, 2023 07:37
@yhabteab yhabteab deleted the add-scan-options-to-jobs-command branch July 19, 2023 07:39
@yhabteab yhabteab removed this from the 1.2.2 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd lippserd requested changes

Assignees

@yhabteab yhabteab

Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scan jobs run by daemon not updating allready scanned Targets
2 participants
@yhabteab @lippserd