Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Add PHP 8.3 #227

Merged
merged 2 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
os: ['ubuntu-latest']

steps:
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ]
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
os: ['ubuntu-latest']

steps:
Expand Down
1 change: 1 addition & 0 deletions application/controllers/UsageController.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public function indexAction()
$this->addControl($searchBar);

$this->handleFormatRequest($targets, function (Query $targets) {
/** @var X509Certificate $usage */
foreach ($targets as $usage) {
$usage->valid_from = $usage->valid_from->format('l F jS, Y H:i:s e');
$usage->valid_to = $usage->valid_to->format('l F jS, Y H:i:s e');
Expand Down
36 changes: 3 additions & 33 deletions phpstan-baseline-common.neon
Original file line number Diff line number Diff line change
Expand Up @@ -241,23 +241,8 @@ parameters:
path: application/controllers/SniController.php

-
message: "#^Cannot access property \\$chain on mixed\\.$#"
count: 4
path: application/controllers/UsageController.php

-
message: "#^Cannot access property \\$hostname on mixed\\.$#"
count: 1
path: application/controllers/UsageController.php

-
message: "#^Cannot access property \\$ip on mixed\\.$#"
count: 1
path: application/controllers/UsageController.php

-
message: "#^Cannot access property \\$port on mixed\\.$#"
count: 1
message: "#^Cannot access property \\$target on mixed\\.$#"
count: 3
path: application/controllers/UsageController.php

-
Expand All @@ -266,20 +251,10 @@ parameters:
path: application/controllers/UsageController.php

-
message: "#^Cannot access property \\$valid_from on mixed\\.$#"
count: 2
path: application/controllers/UsageController.php

-
message: "#^Cannot access property \\$valid_to on mixed\\.$#"
message: "#^Cannot call method format\\(\\) on mixed\\.$#"
count: 2
path: application/controllers/UsageController.php

-
message: "#^Cannot call method getExportableColumns\\(\\) on mixed\\.$#"
count: 1
path: application/controllers/UsageController.php

-
message: "#^Method Icinga\\\\Module\\\\X509\\\\Controllers\\\\UsageController\\:\\:completeAction\\(\\) has no return type specified\\.$#"
count: 1
Expand All @@ -295,11 +270,6 @@ parameters:
count: 1
path: application/controllers/UsageController.php

-
message: "#^Parameter \\#1 \\$iterator of function iterator_to_array expects Traversable, mixed given\\.$#"
count: 1
path: application/controllers/UsageController.php

-
message: "#^Parameter \\#1 \\$peekAhead of method ipl\\\\Orm\\\\Query\\:\\:peekAhead\\(\\) expects bool, null given\\.$#"
count: 1
Expand Down