Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RewriteFilterBehavior::rewriteCondition() Argument and return type do not match #45

Open
lippserd opened this issue Apr 8, 2022 · 0 comments · May be fixed by #74
Open

RewriteFilterBehavior::rewriteCondition() Argument and return type do not match #45

lippserd opened this issue Apr 8, 2022 · 0 comments · May be fixed by #74
Assignees
@nilmerg
Labels
bug Something isn't working
Milestone
Behavior and perf...

Comments

@lippserd
Copy link
Member

lippserd commented Apr 8, 2022

RewriteFilterBehavior::rewriteCondition() expects Filter\Condition but allows Filter\Rule to be returned. This can also return Chain, such as in FlattenedObjectVars. This breaks any behavior that follows a behavior that returns something other than Filter\Condition, as behaviors are processed sequentially, using the previous behavior's result for the current one.
@lippserd lippserd added the bug Something isn't working label Apr 8, 2022
@lippserd lippserd added this to the v0.4.0 milestone Apr 8, 2022
lippserd added a commit to Icinga/icingadb-web that referenced this issue Apr 11, 2022
@lippserd
Process FlattenedObjectVars behavior last
9e581e7 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue Apr 13, 2022
@lippserd
Process FlattenedObjectVars behavior last
1814958 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue Apr 27, 2022
@lippserd
Process FlattenedObjectVars behavior last
16c0e18 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue May 3, 2022
@lippserd
Process FlattenedObjectVars behavior last
43101ce 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue May 5, 2022
@lippserd
Process FlattenedObjectVars behavior last
574089e 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue May 19, 2022
@lippserd
Process FlattenedObjectVars behavior last
65a3e79 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
lippserd added a commit to Icinga/icingadb-web that referenced this issue May 23, 2022
@lippserd
Process FlattenedObjectVars behavior last
30a7f56 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
nilmerg pushed a commit to Icinga/icingadb-web that referenced this issue May 24, 2022
@lippserd @nilmerg
Process FlattenedObjectVars behavior last
aeaf1be 
FlattenedObjectvars returns an incompatible type for a subsequent
behavior:

Icinga/ipl-orm#45
@nilmerg nilmerg removed this from the v0.4.0 milestone Jun 15, 2022
@nilmerg nilmerg self-assigned this Aug 19, 2022
nilmerg added a commit that referenced this issue Aug 19, 2022
@nilmerg
Behaviors: Abort filter condition processing upon type change
b454e0f 
This relies on the fact that the `FilterProcessor` re-evaluates
the behaviors for a changed filter. So any skipped behaviors
then get their chance to process the result.

fixes #45
@nilmerg nilmerg linked a pull request Aug 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
bug Something isn't working
Projects
None yet
Milestone
Behavior and performance enhancements
Development

Successfully merging a pull request may close this issue.

Behaviors: Abort filter condition processing upon type change Icinga/ipl-orm
2 participants
@lippserd @nilmerg