Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to timezone specific datetime helpers to avoid use deprecated functions #86

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

bednar
Copy link
Member

@bednar bednar commented May 2, 2024

Proposed Changes

image
image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from karel-rehor May 2, 2024 07:54
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.39%. Comparing base (c580008) to head (4da8d38).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   50.52%   53.39%   +2.86%     
==========================================
  Files          39       40       +1     
  Lines        2276     2285       +9     
==========================================
+ Hits         1150     1220      +70     
+ Misses       1126     1065      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review May 2, 2024 07:54
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Looks OK.

@bednar bednar merged commit a030485 into main Jun 12, 2024
13 checks passed
@bednar bednar deleted the datetime-deprecation branch June 12, 2024 09:40
@bednar bednar added this to the 0.6.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants