Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Tile Tabs 10.0: tabs opened from private tabs doesn't becomes private #83

Closed
Infocatcher opened this issue Jul 31, 2013 · 8 comments

Comments

@Infocatcher
Copy link
Owner

Tile Tabs: https://addons.mozilla.org/firefox/addon/tile-tabs/
(all works fine with Tile Tabs 9.2)

STR:

  1. Open any page in private tab.
  2. Middle-click on any link.
  3. New tab will be opened with "New Tab" label instead of "Connecting…"/"Loading…" (visible only until page title not yet received) and will be not private.

And Private Tab check label of new tabs to detect empty tabs, based on
chrome://browser/content/tabbrowser.xml

      <method name="addTab">
        ...
            var uriIsAboutBlank = !aURI || aURI == "about:blank";

            if (!aURI || isBlankPageURL(aURI))
              t.setAttribute("label", this.mStringBundle.getString("tabs.emptyTabTitle"));
            else
              t.setAttribute("label", aURI);

Also Private Tab works correct without following statements (but tab label still wrong):
chrome\content\tiletabs-browser.js

    onTabOpen: function(event)
    {
        ...
        if (gBrowser.selectedTab.hasAttribute("tiletabs-assigned") && tileTabs.viewTiled)
        {
            tileTabs.hideAllPanels();
            tileTabs.drawActiveLayout();
            tileTabs.highlightPanel();
        }
        else
        {
            tileTabs.hideAllPanels();
            tileTabs.drawSelectedPanel();
        }
        tileTabs.styleTiledTabs();
    },

Anyway, wrong tab label is a Tile Tabs bug and (probably) no possible workaround from Private Tab side.

@notpeelz
Copy link

notpeelz commented Aug 1, 2013

I second this, I have been experiencing the same issue since I have installed Tile Tabs.

I run Firefox rev 22, Tile Tabs 10.0, Private Tabs 0.1.3.

@Infocatcher
Copy link
Owner Author

I emailed to author using "Support E-mail" from AMO page, but he hasn't yet answered.

@Infocatcher
Copy link
Owner Author

Seems like Private Tab works correctly with this workaround: f5524fc
Test version: private_tab-0.1.4pre4-fx-sm.xpi (source).

@Infocatcher
Copy link
Owner Author

(Tile Tabs still buggy with tab labels, but Private Tab handles tabs earlier.)

@notpeelz
Copy link

notpeelz commented Aug 1, 2013

This seems to have fixed the issue (for now at least). Thanks.

Looking forward for the full patch.

@Infocatcher
Copy link
Owner Author

I emailed to author using "Support E-mail" from AMO page, but he hasn't yet answered.

I've got answer from author with attached Tile Tabs 10.1 Beta 1.
It seems all works fine for me (now all OK with tab labels) with Private Tab 0.1.3 and with current development version.

@notpeelz
Copy link

notpeelz commented Aug 1, 2013

All good. Thank you 👍

@Infocatcher
Copy link
Owner Author

Tile Tabs 10.1: https://addons.mozilla.org/addon/tile-tabs/versions/10.1 (not yet reviewed) and I will release Private Tab 0.1.4 with fixes for Tile Tabs 10.0 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants