Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ruamel import in __init__.py from v0.38.0 #923

Closed
IL-William opened this issue Nov 5, 2023 · 3 comments · Fixed by #925
Closed

Incorrect ruamel import in __init__.py from v0.38.0 #923

IL-William opened this issue Nov 5, 2023 · 3 comments · Fixed by #925

Comments

@IL-William
Copy link

IL-William commented Nov 5, 2023

from ruamel.yaml import StreamTextType, StreamType, VersionType

Hi there,
After installing piperider for the first time, I get the following ruaml issue

Screenshot 2023-11-05 at 10 31 07

Looking at the specified file, I can see that the import is as follow

from ruamel.yaml import StreamTextType, StreamType, VersionType

This file was inserted from v0.38.0.

I can see that it is specified that ruaml should be < 0.17.40.

However, I had a look at ruamel repo using 0.17.40, and I can see it was already using from ruamel.yaml.compat

Screenshot 2023-11-05 at 10 33 38

This means that the import should be as follows

from ruamel.yaml.compat import StreamTextType, StreamType, VersionType

Alternatively, I don't know if the requested version should be downgraded to work as it is currently?

After manual modification, I can use piperider.

Screenshot 2023-11-05 at 10 35 09

In the meantime, I'll use v0.37.1 as this file was not existing yet, and there is no issue currently with it.

@IL-William IL-William changed the title Use ruamel.yaml.compat to import StreamTextType, StreamType, VersionType Incorrect ruamel import in __init__.py from v0.38.0 Nov 5, 2023
@popcornylu
Copy link
Contributor

popcornylu commented Nov 6, 2023

Hi @IL-William, Thanks for your feedback.

I have opened sc-32539 for internal tracking.

@popcornylu
Copy link
Contributor

May be related to #912

@popcornylu
Copy link
Contributor

Fixed in release v0.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants