Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Make the ruamel integeration compatiable with legacy versions #925

Merged

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Nov 7, 2023

Fix #923

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

  • Make the yaml parser more compatible with legacy versions

Which issue(s) this PR fixes:

sc-32539

Special notes for your reviewer:

We also re-arrange the test matrix by tox.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #925 (3b558cf) into main (02b474b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   48.48%   48.48%   -0.01%     
==========================================
  Files          63       63              
  Lines        9066     9064       -2     
==========================================
- Hits         4396     4395       -1     
+ Misses       4670     4669       -1     
Files Coverage Δ
piperider_cli/yaml/__init__.py 72.97% <100.00%> (-1.39%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>
Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>
@qrtt1 qrtt1 force-pushed the bug/sc-32539/remove-type-hints-for-compatiable-legacy-versions branch from 8b53531 to 4a871e6 Compare November 7, 2023 08:24
Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>
@qrtt1 qrtt1 force-pushed the bug/sc-32539/remove-type-hints-for-compatiable-legacy-versions branch from 668bbb4 to 3b558cf Compare November 7, 2023 08:50
Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qrtt1 qrtt1 merged commit 2e487ff into main Nov 7, 2023
26 checks passed
@popcornylu
Copy link
Contributor

Fix #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect ruamel import in __init__.py from v0.38.0
3 participants