Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] sc-32474 Fix compare error if no global dbt config #910

Merged

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bugfix

What this PR does / why we need it:

  • If the dbt config is configured under the data source field. Handle this edge case.
dataSources:
- name: infusetude_dev
  type: snowflake
  dbt:
    profile: infusetude
    target: dev
    projectDir: .
    profilesDir: .
- name: infusetude
  type: snowflake
  dbt:
    profile: infusetude
    target: prod
    projectDir: .
    profilesDir: .
...

Which issue(s) this PR fixes:
sc-32474

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Signed-off-by: Kent Huang <kent@infuseai.io>
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #910 (3e83948) into main (62890e7) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   47.97%   47.95%   -0.03%     
==========================================
  Files          77       77              
  Lines       10726    10740      +14     
==========================================
+ Hits         5146     5150       +4     
- Misses       5580     5590      +10     
Files Coverage Δ
piperider_cli/recipes/__init__.py 23.74% <33.33%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit 50d19c5 into main Oct 23, 2023
30 checks passed
@kentwelcome kentwelcome deleted the bug/sc-32474/bug-piperider-config-loader-should-support branch October 23, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants