Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] introduce Anti-corruption Layer for yaml library #913

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 24, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

chore

What this PR does / why we need it:

The latest yaml library will break our code, we must make it compatible.

Which issue(s) this PR fixes:

sc-32483

@qrtt1 qrtt1 marked this pull request as draft October 24, 2023 05:29
@qrtt1 qrtt1 force-pushed the chore/sc-32483/upgrade-yaml-library branch from d8c7ada to 3e826db Compare October 24, 2023 05:30
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #913 (d34758e) into main (bf71b4a) will increase coverage by 0.07%.
The diff coverage is 60.67%.

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   47.94%   48.01%   +0.07%     
==========================================
  Files          77       78       +1     
  Lines       10740    10751      +11     
==========================================
+ Hits         5149     5162      +13     
+ Misses       5591     5589       -2     
Files Coverage Δ
piperider_cli/cloud/__init__.py 25.17% <ø> (-0.52%) ⬇️
piperider_cli/dbtutil.py 66.91% <100.00%> (-0.13%) ⬇️
piperider_cli/initializer.py 46.15% <100.00%> (+0.34%) ⬆️
piperider_cli/event/__init__.py 79.81% <83.33%> (-0.19%) ⬇️
piperider_cli/__init__.py 52.04% <33.33%> (+0.17%) ⬆️
piperider_cli/assertion_engine/assertion.py 56.93% <50.00%> (-0.09%) ⬇️
piperider_cli/recipes/__init__.py 23.63% <40.00%> (-0.12%) ⬇️
piperider_cli/configuration.py 60.34% <46.15%> (+0.12%) ⬆️
piperider_cli/assertion_engine/recommender.py 36.50% <16.66%> (-1.96%) ⬇️
piperider_cli/yaml/__init__.py 74.35% <74.35%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>
@qrtt1 qrtt1 force-pushed the chore/sc-32483/upgrade-yaml-library branch from 3e826db to d34758e Compare October 24, 2023 06:35
@qrtt1 qrtt1 marked this pull request as ready for review October 24, 2023 07:17
@qrtt1
Copy link
Contributor Author

qrtt1 commented Oct 24, 2023

Our dependency requests a lower version, we won't upgrade for now.

dbt-labs/metricflow@5b02b59

@qrtt1 qrtt1 merged commit c35b2b7 into main Oct 24, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant