[Maintenance] performance forEach on range

- `forEach` function [Performs the given operation on each element of this Iterator.](https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/for-each.html). - `for` loop [A for loop over a range or an array is compiled to an index-based loop that does not create an iterator object.](https://kotlinlang.org/docs/control-flow.html#for-loops) First one will create `Iterator` object, second will not. It was used like that only in tests. But gaining slightly faster tests is good in my opinion.
InsertKoinIO · Sep 22, 2024 · 4eb1548 · 4eb1548
1 parent 74f9198
commit 4eb1548
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/projects/core/koin-core-coroutines/src/jvmTest/kotlin/org/koin/test/PerfsTest.kt b/projects/core/koin-core-coroutines/src/jvmTest/kotlin/org/koin/test/PerfsTest.kt
@@ -1,12 +1,18 @@
 package org.koin.test
 
 import kotlinx.coroutines.runBlocking
-import org.koin.core.*
 import org.koin.core.context.GlobalContext.startKoin
 import org.koin.core.context.GlobalContext.stopKoin
 import org.koin.core.context.waitKoinStart
-import org.koin.core.logger.*
+import org.koin.core.isAllStartedJobsDone
+import org.koin.core.lazyModules
+import org.koin.core.logger.EmptyLogger
+import org.koin.core.logger.Level
+import org.koin.core.logger.Logger
+import org.koin.core.onKoinStarted
+import org.koin.core.runOnKoinStarted
 import org.koin.core.time.Timer
+import org.koin.core.waitAllStartJobs
 import org.koin.dsl.koinApplication
 import org.koin.mp.KoinPlatform
 import kotlin.test.Test
@@ -15,12 +21,16 @@ class PerfsTest {
 
     @Test
     fun perfModule400_module_perfs() {
-        (1..3).forEach { runPerfs() }
+        for (index in 1..3) {
+            runPerfs()
+        }
     }
 
     @Test
     fun perfModule400_lazy_module_perfs() {
-        (1..3).forEach { runPerfs(isLazy = true) }
+        for (index in 1..3) {
+            runPerfs(isLazy = true)
+        }
     }
 
     private fun runPerfs(log: Logger = EmptyLogger(), isLazy: Boolean = false) {

diff --git a/projects/core/koin-core/src/commonTest/kotlin/org/koin/core/ParameterStackTest.kt b/projects/core/koin-core/src/commonTest/kotlin/org/koin/core/ParameterStackTest.kt
@@ -24,7 +24,7 @@ class ParameterStackTest {
             )
         }.koin
 
-        (1..10).forEach {
+        for (index in 1..10) {
             koin.get<Simple.MyStringFactory> { parametersOf(KoinPlatformTools.generateId()) }
         }
 

diff --git a/projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/DebugLogTest.kt b/projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/DebugLogTest.kt
@@ -15,7 +15,7 @@ class DebugLogTest {
             printLogger(Level.INFO)
         }.koin
 
-        (1..10).forEach {
+        for (index in 1..10) {
             measureDuration("with if") {
                 if (koin.logger.isAt(Level.DEBUG)) {
                     koin.logger.debug(message { "test me" })

diff --git a/projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/instance/CreateAPITest.kt b/projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/instance/CreateAPITest.kt
@@ -1,6 +1,8 @@
 package org.koin.core.instance
 
-import org.junit.Assert.*
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNotEquals
+import org.junit.Assert.fail
 import org.junit.Test
 import org.koin.core.error.InstanceCreationException
 import org.koin.core.logger.Level
@@ -123,7 +125,7 @@ class CreateAPITest {
             )
         }.koin
 
-        (1..3).forEach {
+        for (index in 1..3) {
             koin.get<Component>()
         }
     }