Make KoinWorkerFactory match androidx.work.WorkerFactory API
#1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin `androidx.work.WorkerFactory` has `@Nullable` annotation on abstract method `createWorker`. Inherited `KoinWorkerFactory` has overriden return type of `createWorker` with non-null `ListenableWorker`. In some edge cases that leads to crash with `org.koin.core.error.NoBeanDefFoundException`.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin
androidx.work.WorkerFactoryhas@Nullableannotation onabstract method
createWorker. InheritedKoinWorkerFactoryhasoverriden return type of
createWorkerwith non-nullListenableWorker.In some edge cases that leads to
crash with
org.koin.core.error.NoBeanDefFoundException.Work Managers framework uses reflection to retrieve scheduled workers.
It stores worker fully qualified name in database. If your application
scheduled some work and you changed name or package of that work
in new version of application,
WorkerFactorycouldn't build scheduledworker, because of not found stored worker name. Default implementation
will skip that case with
nullworker.